Skip to content

Conversation

@Rados13
Copy link
Contributor

@Rados13 Rados13 commented Apr 18, 2024

Acknowledging the stipulations set forth:

  • I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context.
  • I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.

Blocked by: fishjam-dev/protos#18
Elixir SDK PR
Python SDK PR

@Rados13 Rados13 self-assigned this Apr 18, 2024
@codecov
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Merging #183 (95c4ce8) into main (69e3a61) will increase coverage by 0.06%.
The diff coverage is 84.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   86.85%   86.91%   +0.06%     
==========================================
  Files          74       74              
  Lines        1491     1498       +7     
==========================================
+ Hits         1295     1302       +7     
  Misses        196      196              
Files Coverage Δ
lib/jellyfish/event.ex 87.87% <100.00%> (+0.78%) ⬆️
lib/jellyfish/room.ex 80.27% <100.00%> (-0.14%) ⬇️
lib/jellyfish/room/state.ex 87.89% <80.00%> (+0.48%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e3a61...95c4ce8. Read the comment docs.

@Rados13 Rados13 marked this pull request as ready for review April 22, 2024 07:17
@Rados13 Rados13 requested review from roznawsk and sgfn April 22, 2024 07:17
@Rados13 Rados13 removed the request for review from roznawsk April 23, 2024 08:58
@Rados13 Rados13 merged commit 325318e into main Apr 23, 2024
@Rados13 Rados13 deleted the feature/RTC-520/peer_added_peer_removed branch April 23, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants