RTC-510 Recording manual subscribe mode #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rados13
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 87.31% 86.97% -0.35%
==========================================
Files 72 72
Lines 1388 1397 +9
==========================================
+ Hits 1212 1215 +3
- Misses 176 182 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Rados13
force-pushed
the
recording_manual_subscribe_mode
branch
5 times, most recently
from
1b8572c to
85dd78c
Compare
Karolk99
approved these changes
Apr 8, 2024
lib/jellyfish/component/recording.ex
Outdated
| """) | ||
|
|
||
| with {:ok, serialized_opts} <- serialize_options(options, Options.schema()), | ||
| result_opts <- Map.update!(serialized_opts, :subscribe_mode, &String.to_atom/1), |
Contributor
There was a problem hiding this comment.
Suggestion: I would wrap this line in function get_subscribe_mode or parse_subscribe_mode for consistency
lib/jellyfish/room.ex
Outdated
| end | ||
|
|
||
| defp get_hls_component(%{components: components}), | ||
| defp get_component_by_id(%{components: components} = _state, component_id), |
Contributor
There was a problem hiding this comment.
Suggested change
| defp get_component_by_id(%{components: components} = _state, component_id), | |
| defp get_component_by_id(%{components: components}, component_id), |
Rados13
force-pushed
the
recording_manual_subscribe_mode
branch
from
4c52688 to
83c7a6c
Compare
sgfn
reviewed
Apr 8, 2024
sgfn
approved these changes
Apr 9, 2024
| "id" => id, | ||
| "type" => "recording", | ||
| "properties" => %{"pathPrefix" => path_prefix} | ||
| "properties" => path_prefix |
Member
There was a problem hiding this comment.
Shouldn't this variable be named properties?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acknowledging the stipulations set forth:
PR in Elixir SDK
PR in Python SDK
PR in Docs