Skip to content

Conversation

@Karolk99
Copy link
Contributor

@Karolk99 Karolk99 commented Dec 1, 2023

Acknowledging the stipulations set forth:

  • I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context.
  • I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.

@codecov
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #124 (4ca1e60) into main (6538d54) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files          54       54           
  Lines         992      992           
=======================================
  Hits          855      855           
  Misses        137      137           
Files Coverage Δ
lib/jellyfish_web/controllers/recording_json.ex 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6538d54...4ca1e60. Read the comment docs.

Copy link
Contributor

@Rados13 Rados13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't the scope of this PR, but we should think about a way to check the returned JSON structure with generated OpenApiSpec automatically.

@Karolk99
Copy link
Contributor Author

Karolk99 commented Dec 5, 2023

It isn't the scope of this PR, but we should think about a way to check the returned JSON structure with generated OpenApiSpec automatically.

https://membraneframework.atlassian.net/jira/software/c/projects/RTC/boards/18/backlog?selectedIssue=RTC-419

@Karolk99 Karolk99 merged commit 9d8670d into main Dec 5, 2023
@Karolk99 Karolk99 deleted the fix-get-recordings branch December 5, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants