File component framerate #52
Conversation
| @enforce_keys [:file_path] | ||
| defstruct @enforce_keys ++ | ||
| [] | ||
| defstruct @enforce_keys ++ [framerate: nil] |
There was a problem hiding this comment.
Consider removing the default nil - this would require JF to always return value, even if it's nil.
There was a problem hiding this comment.
Not exactly; it would require the user always to pass a value, even if it is adding an audio file component.
There was a problem hiding this comment.
Perhaps we can clean up rooms after each test more easily with a combination of setup and on_exit ?
Maybe its possible to create a function like this:
def cleanup_on_exit do
on_exit(fn _ -> remove_all_rooms())
end
and then call it on setup of each describe block?
I am not sure if this would work, perhaps this discussion might help:
https://elixirforum.com/t/how-to-clean-up-after-each-test-inside-describe/23718
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 82.01% 82.01%
=======================================
Files 16 16
Lines 228 228
=======================================
Hits 187 187
Misses 41 41
Continue to review full report in Codecov by Sentry.
|
Blocked by this PR