BUG: Fix EquationBC + matfree + fieldsplit #4734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The fix looks sensible, but I'm not clear on why the test needed changing. Was it incorrect before? |
Contributor
Author
The test was previously passing because we had a Krylov method. These options should have converged after one iteration, but they were taking 8 steps due to the bug. The test now applies these options as a direct solver, so if anything is wrong with BCs and fieldsplit it should fail to solve the problem in one iteration. |
JHopeCollins
approved these changes
Nov 20, 2025
Member
JHopeCollins
left a comment
JHopeCollins
left a comment
There was a problem hiding this comment.
I'm happy with this fix. The only test failure is a linkcheck that has been fixed in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4721