Skip to content

voter: remove ignored format specifier #7259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

voter: remove ignored format specifier #7259

wants to merge 1 commit into from
+1 −1

Conversation

@intrigus-lgtm
Copy link
Contributor

@intrigus-lgtm intrigus-lgtm commented Nov 15, 2025

FD_LOG_HEXDUMP_CRIT does not take a format string as input.

Also curious that fd_voter_vote_slot does a hexdump, while vd_voter_root_slot just prints voter->kind.

@intrigus-lgtm
voter: remove ignored format specifier
23333ff 
FD_LOG_HEXDUMP_CRIT does not take a format string as input.
@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.076967 s 0.076876 s -0.118% ✅
backtest mainnet-368528500-perf snapshot load 3.083 s 2.993 s -2.919% ✅
backtest mainnet-368528500-perf total elapsed 76.966881 s 76.876079 s -0.118% ✅
firedancer mem usage with mainnet.toml 997.12 GiB 997.12 GiB 0.000% ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidatong lidatong Awaiting requested review from lidatong lidatong is a code owner

@emwang-jump emwang-jump Awaiting requested review from emwang-jump emwang-jump is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@intrigus-lgtm