Skip to content

flamenco, types: fix unaligned access in fd_rust_duration_footprint_validator #7256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

flamenco, types: fix unaligned access in fd_rust_duration_footprint_validator #7256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/flamenco/types/fd_types_custom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,16 @@ fd_rust_duration_normalize ( fd_rust_duration_t * self ) {
//
int
fd_rust_duration_footprint_validator ( fd_bincode_decode_ctx_t * ctx ) {
fd_rust_duration_t *d = (fd_rust_duration_t *) ctx->data;
if( d->nanoseconds < 1000000000U )
if( (ulong)ctx->data + ( sizeof(ulong) + sizeof(uint) ) > (ulong)ctx->dataend )
return FD_BINCODE_ERR_OVERFLOW;

ulong seconds = FD_LOAD( ulong, ctx->data );
uint nanoseconds = FD_LOAD( uint, (uchar*)ctx->data + sizeof(ulong) );

if( nanoseconds < 1000000000U )
return FD_BINCODE_SUCCESS;
ulong out;
if( __builtin_uaddl_overflow( d->seconds, d->nanoseconds/1000000000U, &out ) )
if( __builtin_uaddl_overflow( seconds, nanoseconds/1000000000U, &out ) )
return FD_BINCODE_ERR_ENCODING;
return FD_BINCODE_SUCCESS;
}
Loading