Skip to content

Conversation

@jherrera-jump
Copy link
Contributor

No description provided.

@jherrera-jump jherrera-jump marked this pull request as ready for review November 12, 2025 20:09
@github-actions
Copy link

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.06428 s 0.064146 s -0.208%
backtest mainnet-368528500-perf snapshot load 2.385 s 2.358 s -1.132%
backtest mainnet-368528500-perf total elapsed 64.280454 s 64.145859 s -0.209%
firedancer mem usage with mainnet.toml 996.14 GiB 996.14 GiB 0.000%

@jherrera-jump jherrera-jump force-pushed the jherrera/gui-fix-query-rankings branch from 68f1b8d to 26ecf97 Compare November 17, 2025 20:39
@github-actions
Copy link

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073878 s 0.073648 s -0.311%
backtest mainnet-368528500-perf snapshot load 3.226 s 3.186 s -1.240%
backtest mainnet-368528500-perf total elapsed 73.878261 s 73.648018 s -0.312%
firedancer mem usage with mainnet.toml 997.12 GiB 997.12 GiB 0.000%

fd_gui_clear_slot( fd_gui_t * gui,
ulong _slot,
ulong _parent_slot ) {
gui->summary.startup_slot = fd_ulong_if( gui->summary.startup_slot==ULONG_MAX, _slot, gui->summary.startup_slot );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit implicit to me .. hard to prove what it ends up being. Isn't it just the genesis or snapshot slot anyway?

@jherrera-jump jherrera-jump marked this pull request as draft November 17, 2025 21:27
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-fix-query-rankings branch from 26ecf97 to ef8c5dd Compare November 17, 2025 21:56
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-fix-query-rankings branch from ef8c5dd to 7006d42 Compare November 17, 2025 22:22
@jherrera-jump jherrera-jump marked this pull request as ready for review November 17, 2025 22:57
@github-actions
Copy link

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073897 s 0.073895 s -0.003%
backtest mainnet-368528500-perf snapshot load 3.212 s 3.191 s -0.654%
backtest mainnet-368528500-perf total elapsed 73.897284 s 73.89549 s -0.002%
firedancer mem usage with mainnet.toml 999.12 GiB 999.12 GiB 0.000%

@jherrera-jump jherrera-jump merged commit 2f00d2c into main Nov 17, 2025
18 checks passed
@jherrera-jump jherrera-jump deleted the jherrera/gui-fix-query-rankings branch November 17, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants