Skip to content

Patch release v0.20.1 #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ioanachirca
Copy link
Contributor

@ioanachirca ioanachirca commented Aug 3, 2020

Reason for This PR

Part of #2057

  • This functionality can be added in rust-vmm.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any newly added unsafe code is properly documented.
  • Any API changes are reflected in firecracker/swagger.yaml.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

acatangiu
acatangiu previously approved these changes Aug 3, 2020
serban300
serban300 previously approved these changes Aug 3, 2020
@ioanachirca ioanachirca force-pushed the release-v0.20.1 branch 2 times, most recently from 67426ea to a5573ea Compare August 3, 2020 14:35
ioanachirca and others added 4 commits August 3, 2020 18:13
This is a regression test for
firecracker-microvm#1444

Signed-off-by: Ioana Chirca <[email protected]>
Validate that the RX queue won't freeze under high stateless ingress
traffic when encountering bottlenecks on the tap.

Signed-off-by: Serban Iorga <[email protected]>
Under heavy ingress traffic we might end up in a situation where the tap
device is full, but the rx.deferred_frame flag is not set. Beeing in
this state the firecracker RX queue becomes effectively blocked. The tap
won't issue any new event because of the EPOLLET flag, while any rate
limiter or RX queue event won't do any processing because the
rx.deferred_frame flag is not set.

We need to make sure we set the rx.deferred_frame flag on all the paths
that leave unprocessed frames in the tap.

Signed-off-by: Serban Iorga <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
Add a new parameter to devtool that fixes
permissions for the build directory (the one that can
get modified by the container).
This way unprivileged users can regain rights
(i.e delete build session) when devtool dies in
the middle of a privileged session.

Signed-off-by: Diana Popa <[email protected]>
Signed-off-by: Ioana Chirca <[email protected]>
@dianpopa dianpopa merged commit 37d357a into firecracker-microvm:fix-v0.20.1 Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants