Raise interrupt for used descriptors on tx queue and use edged triggered epoll. #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreim
added
the
Status: Awaiting review
sandreim
changed the title
serban300
previously approved these changes
Dec 3, 2019
acatangiu
previously approved these changes
Dec 3, 2019
serban300
previously approved these changes
Dec 4, 2019
iulianbarbu
previously approved these changes
Dec 4, 2019
Add a unit test for this regression: firecracker-microvm#1436. Signed-off-by: Andrei Sandu <[email protected]>
Remove register_tap_rx_listener and unregister_tap_rx_listener, and set EPOLLET flag when registering the tap fd. Edged epoll should work fine with the current code as it already tracks unconsumed input from the tap device via *deferred_frame*. When process_rx stops reading frames before EAGAIN it will set deferred_frame flag. The process_rx function will resume processing frames via RX_RATE_LIMITER_EVENT and clear that flag. Signed-off-by: Andrei Sandu <[email protected]>
acatangiu
approved these changes
Dec 4, 2019
serban300
approved these changes
Dec 4, 2019
ioanachirca
added a commit
to ioanachirca/firecracker
that referenced
this pull request
Aug 3, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
to dianpopa/firecracker
that referenced
this pull request
Aug 3, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
ioanachirca
added a commit
to ioanachirca/firecracker
that referenced
this pull request
Aug 3, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
that referenced
this pull request
Aug 4, 2020
This is a regression test for #1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
that referenced
this pull request
Aug 4, 2020
This is a regression test for #1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
to dianpopa/firecracker
that referenced
this pull request
Aug 4, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
to dianpopa/firecracker
that referenced
this pull request
Aug 4, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
to dianpopa/firecracker
that referenced
this pull request
Aug 4, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
ioanachirca
added a commit
to ioanachirca/firecracker
that referenced
this pull request
Aug 4, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
to dianpopa/firecracker
that referenced
this pull request
Aug 4, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
to dianpopa/firecracker
that referenced
this pull request
Aug 4, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
ioanachirca
added a commit
that referenced
this pull request
Aug 4, 2020
This is a regression test for #1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
to dianpopa/firecracker
that referenced
this pull request
Aug 5, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
to dianpopa/firecracker
that referenced
this pull request
Aug 5, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
to dianpopa/firecracker
that referenced
this pull request
Aug 5, 2020
This is a regression test for firecracker-microvm#1444 Signed-off-by: Ioana Chirca <[email protected]>
dianpopa
pushed a commit
that referenced
this pull request
Aug 5, 2020
This is a regression test for #1444 Signed-off-by: Ioana Chirca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
Fixes #1439, #1436 .
Description of Changes
This change will degrade performance as it increases the interrupt rate. It will also improve emulation thread cpu usage.
I've run some benchmarks on a m5d.metal host running a microvm with 2vCPUs and 2GB of RAM.
Without this PR:
With this PR:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria. Where there are two options, keep one.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.mdfile.unsafecode has been added.