Added Force flag to cniConfig, added check on network remove #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sipsma PTAL i would like to add a test for this case, but can't find a proper place in |
sipsma
approved these changes
Nov 11, 2019
Signed-off-by: bpopovschi <[email protected]>
Zyqsempai
force-pushed
the
130-change-default-behavior-for-network-del
branch
from
2edb790 to
d41de9b
Compare
|
@sipsma Done. |
IRCody
approved these changes
Nov 14, 2019
samuelkarp
approved these changes
Nov 14, 2019
pendo324
pushed a commit
to pendo324/firecracker-go-sdk
that referenced
this pull request
Aug 27, 2024
Updater linters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bpopovschi [email protected]
Issue #130
Description of changes:
Added
Forceflag to CNIConfig.Added check of that flag on
delNetworkFuncAdded error log is
Forceflag was set totrueBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.