Add extra verify steps to buildkite for go.mod/go.sum and proto defs #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed there was a difference in generated proto after a recent commit (it was insignificant, just a difference in the comments of the generated .pb.go), so it seemed like a good time to add this check. Signed-off-by: Erik Sipsma <[email protected]>
Signed-off-by: Erik Sipsma <[email protected]>
sipsma
requested review from
kzys,
nmeyerhans,
samuelkarp,
mxpv,
xibz and
IRCody
IRCody
approved these changes
Dec 5, 2019
kzys
approved these changes
Dec 5, 2019
nmeyerhans
approved these changes
Dec 5, 2019
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
Make TestLogAndMetrics work with Firecracker's main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed our go.mod/go.sum and generated proto defs were a bit out of sync (the proto differences were very minor, just differences in the comments of a .pb.go), so figured it was a good time to add some verification steps to buildkite that check if go.mod/go.sum and the proto defs are all up to date.
Closes #323
Verified the steps fail as expected w/ a purposely broken commit here: https://buildkite.com/firecracker-microvm/sipsma-firecracker-containerd/builds/861#
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.