Add numa cpuset support #334
Conversation
xibz
force-pushed
the
jailer-numa-node-clean
branch
8 times, most recently
from
d393477 to
fc75aa0
Compare
xibz
force-pushed
the
jailer-numa-node-clean
branch
2 times, most recently
from
15a8fd2 to
ce46c24
Compare
runtime/cpuset/cpuset_builder.go
Outdated
| sep = "" | ||
| } | ||
|
|
||
| str += fmt.Sprintf("%s%d-%d", sep, r.min, r.max) |
There was a problem hiding this comment.
nit: _range seems like a good candidate for a String() method
runtime/cpuset/cpuset_builder.go
Outdated
| } | ||
|
|
||
| // AddMemRange adds a range of memory nodes by utilizing the minimum node to | ||
| // use to the maximum node to use. |
There was a problem hiding this comment.
I'm not quite sure what you're trying to say here.
|
|
||
| func stringify(elems []int, ranges []_range) string { | ||
| str := "" | ||
| for _, elem := range elems { |
There was a problem hiding this comment.
Any reason for doing this instead of using strings.Join?
There was a problem hiding this comment.
Gah, good call out. Just slipped the mind.
There was a problem hiding this comment.
@xibz Can you update this to use strings.Join?
There was a problem hiding this comment.
This returns a string using Join. Was there something else you had in mind? Cause I think this is probably the simplest way to go?
There was a problem hiding this comment.
@xibz My apologies, I misread this. I might use strconv.Itoa instead of fmt.Sprintf, but that's really minor.
There was a problem hiding this comment.
Ah cool, and no worries! I'll go ahead and fix the fmt.Sprintf issue. Thanks!
| str += fmt.Sprintf("%s%d", sep, elem) | ||
| } | ||
|
|
||
| for _, r := range ranges { |
xibz
force-pushed
the
jailer-numa-node-clean
branch
2 times, most recently
from
a33efce to
c471534
Compare
runtime/jailer_integ_test.go
Outdated
| func TestJailerCPUSet_Isolated(t *testing.T) { | ||
| prepareIntegTest(t, withJailer()) | ||
|
|
||
| t.Run("Jailer NumaNode", func(t *testing.T) { |
There was a problem hiding this comment.
Can you update the name to reflect the new function name?
This change adds support for specifying a set of cpu and memory nodes during the CreateVM call. This will run the jailed process on those set of cpus and restrict access to the specified nodes. This change also adds the cpuset.Builder which allows for easy creation of cpus and mems strings Signed-off-by: xibz <[email protected]>
xibz
force-pushed
the
jailer-numa-node-clean
branch
from
221995e to
29ee484
Compare
Fix BuildKite's race condition
This change adds support for specifying a set of cpu and memory nodes
during the CreateVM call. This will run the jailed process on those set
of cpus and restrict access to the specified nodes. This change also
adds the cpuset.Builder which allows for easy creation of cpus and mems
strings
Signed-off-by: xibz [email protected]
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.