Skip to content

jailer improvements #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xibz opened this issue Sep 13, 2019 · 1 comment
Open

jailer improvements #258

xibz opened this issue Sep 13, 2019 · 1 comment
Assignees
Labels

Comments

@xibz
Copy link
Contributor

xibz commented Sep 13, 2019

This is a list of improvements that should be implemented once this PR has been merged, #249

  1. The jailer should use a user namespace, but currently does not.
  2. Jailer should allow for a custom configuration of jailing through the CreateVM API. Maybe allow complete passing of the configuration. However, this would require writing a bunch of proto definitions. We want memory and cpu to be configurable, as well as numa nodes. We aren't going to copy the runc config into our request as that is really large and most of the fields may not be used. The cpuset.mems and cpuset.cpus has been completed by Add numa cpuset support #334
  3. The jailer should use numa nodes. I believe this can be specified in runc's configuration - Done via Add numa cpuset support #334
  4. Instead of hard linking we should use bind mounts in the jailer handler. Decided that copying was the best solution for now, which is already done. If this changes in the future we can add a separate issue illustrating that.
  5. CreateVMRequest should allow passing of the netns as a parameter. - Done via Adding netns to jailer  #305
@xibz xibz self-assigned this Sep 13, 2019
@xibz xibz mentioned this issue Sep 25, 2019
1 task
@sipsma
Copy link
Contributor

sipsma commented Oct 21, 2019

We should also update the getting-started guide and/or other docs with details on how to use the jailer

@kzys kzys added kind/enhancement New feature or request exp/intermediate labels Feb 19, 2021
fangn2 pushed a commit to fangn2/firecracker-containerd that referenced this issue Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants