Create a small Docker image for running integration tests #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to move "runtime" tests as well, hopefully in this PR. |
kzys
force-pushed
the
tiny-integ-test-image
branch
2 times, most recently
from
1248603 to
d7990de
Compare
IRCody
reviewed
Nov 18, 2019
|
27c842a should be a separate commit. I'm fine about squashing other three into one. |
|
That SGTM. |
It doesn't have to be. Signed-off-by: Kazuyoshi Kato <[email protected]>
Building firecracker-containerd-integ-test takes time and we cannot utilize build cache much since we copy the entire source tree to the container image in the very beginning of the build process. This change introduces firecracker-containerd-integ-test-tiny which doesn't build binaries such as firecracker-containerd (they are built without Docker) but able to run "go test". Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
tiny-integ-test-image
branch
from
27c842a to
8f58ad2
Compare
IRCody
approved these changes
Nov 18, 2019
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
Add "lint" target to check Amazon's license header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#313
Description of changes:
As described in #313, firecracker-containerd-integ-test is copying the entire source directory to the container in the very early stage, which makes incremental build slower. This PR changes the strategy to
That will make incremental build much faster.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.