Skip to content

Support rate-limiters and read-only for drive mounts. #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Support rate-limiters and read-only for drive mounts. #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 80 additions & 57 deletions proto/types.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion proto/types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,15 @@ message FirecrackerDriveMount {
// within the VM (i.e. ["rw", "noatime"]). Defaults to none if not specified.
repeated string Options = 4;

// TODO support for ratelimiters and read-only drives (issue #296)
// (Optional) RateLimiter configuration that will be applied to the
// backing-drive for the VM's rootfs
FirecrackerRateLimiter RateLimiter = 5;

// (Optional) If set to true, IsWritable results in the backing file for the
// drive being opened as read-write by the Firecracker VMM on the host, allowing
// writes to the image from within the guest. Defaults to false, in which case
// the block device in the VM will be read-only.
bool IsWritable = 6;
}

// Message to specify an IO rate limiter with bytes/s and ops/s limits
Expand Down
Loading