Add firewall plugin to demo-network configuration. #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firecracker is now built from a submodule later in the guide, no need to install it beforehand. Signed-off-by: Erik Sipsma <[email protected]>
This plugin results in more consistent success in getting traffic forwarded to/from host networks and the VMs. Signed-off-by: Erik Sipsma <[email protected]>
sipsma
requested review from
kzys,
nmeyerhans,
samuelkarp,
mxpv,
xibz and
IRCody
samuelkarp
approved these changes
Oct 8, 2019
nmeyerhans
approved these changes
Oct 9, 2019
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
…ependabot/go_modules/github.com/go-openapi/strfmt-0.19.10 Bump github.com/go-openapi/strfmt from 0.19.8 to 0.19.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265
Also included a separate small commit to remove some outdated instructions in the getting-started guide that I noticed while working on this.
Tested by running the quickstart guide on a new
m5d.metalw/ Debian Stretch and verifying I by default got internet access from firecracker-containerd containers even when the host had pre-existing Docker iptables rules.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.