Skip to content

Conversation

kzys
Copy link
Contributor

@kzys kzys commented Aug 27, 2019

Issue #, if available: NA

Description of changes:

1.3.x is still beta, but

  • 1.3.x is the first version that has Device Mapper snapshotter
  • 1.2.x doesn't have
    github.com/containerd/containerd/runtime/v2/runc/v2

So, it wouldn't be worth to rewrite our agent to support 1.2.x at this
stage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kzys added 2 commits August 27, 2019 17:03
1.3.x is still beta, but

- 1.3.x is the first version that has Device Mapper snapshotter
- 1.2.x doesn't have
  github.com/containerd/containerd/runtime/v2/runc/v2

So, it wouldn't be worth to rewrite our agent to support 1.2.x at this
stage.

Signed-off-by: Kazuyoshi Kato <[email protected]>
It seems 1.2.x has a conventional PATH by default, but 1.3.x doesn't.

Signed-off-by: Kazuyoshi Kato <[email protected]>
Copy link
Contributor

@sipsma sipsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 8bfaf4f into firecracker-microvm:master Aug 28, 2019
@kzys
Copy link
Contributor Author

kzys commented Aug 30, 2019

Seems we could revert the PATH change, because of containerd/containerd#3597.

fangn2 pushed a commit to fangn2/firecracker-containerd that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants