Make sure containers are deleted correctly #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipsma
reviewed
Jul 17, 2019
|
I initially thought that the issue itself has been resolved, but it seems not.
|
|
Now I think our code was fine but the tests were wrong. Let's see. I'm going to work on the comments after CIs are being green. |
sipsma
reviewed
Jul 18, 2019
| @@ -319,6 +320,10 @@ func (s *service) StartShim(shimCtx context.Context, containerID, containerdBina | |||
| // task is deleted | |||
| containerCount = 1 | |||
| exitAfterAllTasksDeleted = true | |||
|
|
|||
| log.Infof("will start a single-task VM %s since no VMID has been provided", s.vmID) | |||
kzys
force-pushed
the
fix-65
branch
4 times, most recently
from
251278d to
68d2306
Compare
|
All tests are passing finally! |
mxpv
reviewed
Jul 23, 2019
sipsma
reviewed
Jul 23, 2019
sipsma
reviewed
Jul 24, 2019
|
|
||
| resp, err := s.taskManager.DeleteProcess(requestCtx, req, s.agentClient) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if req.ExecID != "" { |
There was a problem hiding this comment.
nit: I'd add a comment explaining why we skip deletion in this case
Before this change, we were only deleting the bundle directory on the deletion of a VM. Due to that, we had symlink conflicts when - We have multiple containers on a single VM - The containers have the same name Closes firecracker-microvm#65. Signed-off-by: Kazuyoshi Kato <[email protected]>
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
cni/cmd/tc-redirect-tap: fix dropped test error
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
* Since firecracker-microvm/firecracker#2125, `cargo build` doesn't build jailer by default. (firecracker-microvm#263) * Fix Benchmark Goroutine (firecracker-microvm#259) * Jailer configuration API cleanup and improved logging with Debug log level (firecracker-microvm#255) * Firecracker is internally has an instance ID, but the SDK didn't have the way to configure the ID. This change connects Config.VMID to the instance ID. (firecracker-microvm#253) * Fixed error that was not being test against in `TestWait` (firecracker-microvm#251) * Fixes issue where socket path may not be defined since the config file has yet to be loaded (firecracker-microvm#230) * Fixed error that was not being test against in `TestNewPlugin` (firecracker-microvm#225) * Download Firecracker 0.21.1 and its jailer from Makefile (firecracker-microvm#218) Signed-off-by: xibz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#65
Description of changes:
While we cannot repro #65 anymore, we'd like to have some tests to
prevent regression.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.