Skip to content

Run quickstart script as a test #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sipsma opened this issue Sep 19, 2019 · 2 comments
Open

Run quickstart script as a test #263

sipsma opened this issue Sep 19, 2019 · 2 comments
Labels
kind/enhancement New feature or request

Comments

@sipsma
Copy link
Contributor

sipsma commented Sep 19, 2019

In order to verify that the quickstart guide works as expected, we should run the script as an e2e test in the CI system. This will likely require figuring out a way of parsing the script out of the markdown and/or having the markdown just reference a standalone script.
@sipsma sipsma added the kind/enhancement New feature or request label Sep 19, 2019
@sipsma sipsma mentioned this issue Sep 19, 2019
Merged
@acpana
Copy link
Contributor

acpana commented Mar 4, 2021

@kzys, can we close out this issue as #257 has been merged?

@kzys
Copy link
Contributor

kzys commented Mar 4, 2021

Hmm, are they related?

fangn2 pushed a commit to fangn2/firecracker-containerd that referenced this issue Mar 23, 2023
@kzys
Merge pull request firecracker-microvm#263 from kzys/jailer-build
0d9acc6 
Build firecracker and jailer explictly
fangn2 pushed a commit to fangn2/firecracker-containerd that referenced this issue Mar 23, 2023
@xibz
Release v0.22.0
2206275 
* Since firecracker-microvm/firecracker#2125, `cargo build` doesn't build jailer by default. (firecracker-microvm#263)
* Fix Benchmark Goroutine (firecracker-microvm#259)
* Jailer configuration API cleanup and improved logging with Debug log level (firecracker-microvm#255)
* Firecracker is internally has an instance ID, but the SDK didn't have the way to configure the ID. This change connects Config.VMID to the instance ID. (firecracker-microvm#253)
* Fixed error that was not being test against in `TestWait` (firecracker-microvm#251)
* Fixes issue where socket path may not be defined since the config file has yet to be loaded (firecracker-microvm#230)
* Fixed error that was not being test against in `TestNewPlugin` (firecracker-microvm#225)
* Download Firecracker 0.21.1 and its jailer from Makefile (firecracker-microvm#218)

Signed-off-by: xibz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kzys @acpana @sipsma