Configuration of firebase.json due to firebase tools 13.0.0 breaking change #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compose � Conflicts: � admob/app/build.gradle � analytics/app/build.gradle � appdistribution/app/build.gradle � auth/app/build.gradle � crash/app/build.gradle � database/app/build.gradle � dynamiclinks/app/build.gradle � functions/app/build.gradle � inappmessaging/app/build.gradle � messaging/app/build.gradle � perf/app/build.gradle � storage/app/build.gradle
…compose � Conflicts: � admob/app/build.gradle � analytics/app/build.gradle � appdistribution/app/build.gradle � auth/app/build.gradle � crash/app/build.gradle � database/app/build.gradle � dynamiclinks/app/build.gradle � inappmessaging/app/build.gradle � perf/app/build.gradle � storage/app/build.gradle
* Added compose Added compose as an option to use Firebase * Added Firebase Config Added Firebase Config functionality * Added initial PR changes Added initial PR changes that Rosário had mentioned. * Updated MainAppView Combined the text and button into the parent composable function * move Firebase logic to RemoteConfigViewModel * Updated imports Updated the MainComposeActivity.kt to remove the wildcard imports and replaced with the appropriate ones * Corrected exceeded max line length error Corrected exceeded max line length error by putting the comment under the code. Corrected build.gradle code to have proper syntax * Updated MainComposeAcitvity.kt Updated MainComposeAcitvity.kt to correct lint error * create RemoteConfigViewModel.Factory to inject VM dependencies A couples of things happened here: - Renamed `fetchConfig()` to `fetchRemoteConfig()` - Created ViewModel Factory to help inject VM dependencies - Moved FirebaseRemoteConfig initialization to the ViewModel (The UI now calls these methods when the screen is created, through a DisposableEffect) - The default value from the XML file is now shown when the screen is first shown * use the same ViewModel in the Kotlin+XML Activity * use Coroutines to fetch remote config instead of OnCompleteListener * add all caps and loading phrase parameters * delete snippets from java MainActivity * chore: update ktlint version * Updated MainComposeActivity Restructured the UI by implementing Scaffold * Added right imports Added scaffold and fillMaxWidth imports. Currently having issues with the Scaffold and the experimental wanting it to use wildcard statements * Migrated from Material 3 to Material 2 Migrated the code from Material 3 to 2. Also updated Gradle file to use Compose 1.3 * Added snackbar Added snackbar when config button is pressed. * androidx.compose.material.Text --> Text --------- Co-authored-by: rosariopf <[email protected]>
…ill only reserve functions directory when there is a functions configuration entry in firebase.json that does not specify the source directory.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to firebase-tools 13.0.0 breaking change #6555, Firebase CLI will only reserve functions directory when there is a functions configuration entry in firebase.json that does not specify the source directory.