refactor(plugins/googleai): migrate to v2 API #3479
+199
−258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabljac
force-pushed
the
@invertase/migrate-googleai-plugin
branch
2 times, most recently
from
3126f71 to
df51ca8
Compare
CorieW
reviewed
Aug 26, 2025
CorieW
approved these changes
Aug 26, 2025
|
(Giving this another self-review and some manual testing) |
cabljac
force-pushed
the
@invertase/migrate-googleai-plugin
branch
from
d74f7f4 to
f66475b
Compare
pavelgj
reviewed
Sep 16, 2025
| async () => { | ||
| return genkitPluginV2({ | ||
| name: 'googleai', | ||
| async init() { |
There was a problem hiding this comment.
@ifielker can we drop init function? Is there anything here that can't be dynamically resolved by the resolver? and/or not returned by list?
ifielker
reviewed
Sep 16, 2025
cabljac
commented
Sep 16, 2025
cabljac
commented
Sep 16, 2025
cabljac
commented
Sep 16, 2025
ah, I thought it was plugins/google-genai/googleai... but either way, we might as well, so that we don't have loose ends w.r.t. to the v2 plugin api migration. We haven't done much planning on exactly how we're going to deprecate this plugin... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the googleai plugin to the v2 API
Resolves #3443