Skip to content

Conversation

@domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented May 18, 2020

Description

Copy of flutter/plugins#2764 cc: @cyanglaz

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@domesticmouse
Copy link
Contributor Author

PTAL @kroikie

@domesticmouse domesticmouse changed the title Run the publishable check from flutter master [all] Run the publishable check from flutter master May 18, 2020
@domesticmouse domesticmouse changed the title [all] Run the publishable check from flutter master chore: Run the publishable check from flutter master May 18, 2020
@cyanglaz
Copy link

LGTM!

@firebase firebase locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants