feat(database): add support for Pigeon. Update iOS to Swift and Android to Kotlin #17686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelVerdon
force-pushed
the
database-migrations-pigeon
branch
from
8c2abeb to
805c16d
Compare
russellwheatley
requested changes
Oct 9, 2025
...e/android/src/main/kotlin/io/flutter/plugins/firebase/database/FlutterDataSnapshotPayload.kt
Outdated
Show resolved
Hide resolved
packages/firebase_database/firebase_database/ios/firebase_database.podspec
Outdated
Show resolved
Hide resolved
...ase_database/ios/firebase_database/Sources/firebase_database/FLTFirebaseDatabasePlugin.swift
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,678 @@ | |||
| // Copyright 2025 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
This class shouldn't exist, it should be on the FLTFirebaseDatabasePlugin class
| 'GCC_PREPROCESSOR_DEFINITIONS' => "LIBRARY_VERSION=\\\"#{library_version}\\\" LIBRARY_NAME=\\\"flutter-fire-rtdb\\\"", | ||
| 'DEFINES_MODULE' => 'YES' | ||
| 'DEFINES_MODULE' => 'YES', | ||
| 'SWIFT_INCLUDE_PATHS' => '"${PODS_TARGET_SRCROOT}/firebase_database/Sources"' |
| @@ -0,0 +1,674 @@ | |||
| // Copyright 2025 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
All macOS files need to be symlinked to iOS files otherwise they won't be updated when we update iOS code.
| @@ -0,0 +1,1742 @@ | |||
| // Copyright 2025, the Chromium project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
remove all windows code, need to update pigeons/messages.dart
| } else if (value is List) { | ||
| childChildKeys = List<String>.generate( | ||
| value.length, | ||
| (int index) => '${index - 1}', |
There was a problem hiding this comment.
how come this has changed?
| FirebaseApp app; | ||
| } | ||
|
|
||
| class _TransactionHandlerFlutterApi extends pigeon.FirebaseDatabaseFlutterApi { |
There was a problem hiding this comment.
could you follow the pattern for using pigeon api for other plugins using it? This doesn't seem right.
Comment on lines
+19
to
+20
| cppHeaderOut: '../firebase_database/windows/messages.g.h', | ||
| cppSourceOut: '../firebase_database/windows/messages.g.cpp', |
…kotlin/io/flutter/plugins/firebase/database/FlutterDataSnapshotPayload.kt Co-authored-by: Russell Wheatley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?