-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[firebase_core] Add macOS support #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_core] Add macOS support #1704
Conversation
f747f47 to
1dd83fc
Compare
1dd83fc to
e77c154
Compare
collinjackson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @amirh and @franciscojma86. I think it is OK to use symlinks to share implementation between iOS and MacOS (since they're the same). I've updated the PR to do this.
|
Thanks @collinjackson and @franciscojma86 for working on this. I guess I will leave this PR to you as you have write access to my branch. Let me know if you want me to work on this again. |
|
I tried this package and get the following issue: |
|
@flowhorn I don't know. Do you have more output than this? Please provide the output of @collinjackson / @franciscojma86 What about testing? Should I write XCTests? |
|
It's the lastest master, here is the output:
Do I need to setup anything? What about the GoogleServices? I tried to use them from the ios side. |
Per our discussion on #1707 the integration test is sufficient. |
7020875 to
2484705
Compare
|
@collinjackson || @franciscojma86 do you know why this task thinks that there is no macOS desktop project configured? There is a |
|
I think that's because you need to include your .xcworkspace as well, but it's being gitignored. Sent #1996 to hopefully fix this and then your PR should work |
| @@ -0,0 +1,6 @@ | |||
| # Flutter-related | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need a gitignore at this level. The root gitignore should be enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what flutter create . did. Maybe it should be removed from there then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well flutter create doesn't know there's a root level .gitignore :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True :) But this one also ignores **/Flutter/ephemeral/ and maybe more which is missing from the root level one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add **/Flutter/ephemeral/ to the root .gitignore or do we leave it as it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave it as is right now. I'll add it to the root ignore and remove from here if needed in another PR
|
@franciscojma86 the failing test seems unrelated. Maybe you can re-run it? As soon as this is merged and released I will update the other PRs so they pass their tests. |
|
Thank you for your patience @cbenhagen ! Looking forward to reviewing the other PRs as well. 🎉 |
|
Thank you for the review! Do you release the package manually or will it be released automatically at some point? |
|
Done! |
Description
Add macOS support.
Related Issues
#1653
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?