Skip to content

Conversation

@cyanglaz
Copy link

@cyanglaz cyanglaz commented Dec 11, 2019

flutterfire version for flutter/plugins#2396

@cyanglaz cyanglaz requested a review from amirh December 11, 2019 03:07
@cyanglaz
Copy link
Author

@fkorotkov Could you take a look at this :)

@cyanglaz cyanglaz changed the title Add only_if: $CIRRUS_TAG == '' to not run CI on release [skip ci] don't run Cirrus on tags Dec 11, 2019
@fkorotkov
Copy link
Contributor

LGTM. Should've add [skip ci] right away to actually skip CI. 😅

@cyanglaz cyanglaz closed this Dec 11, 2019
@cyanglaz cyanglaz reopened this Dec 11, 2019
@cyanglaz
Copy link
Author

The Ci failure is caused by cancellation. We don't need to run all the tests for this PR since it is just a cirrus script change. Planning to merge it on red.

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit fcdb752 into firebase:master Dec 11, 2019
@cyanglaz cyanglaz deleted the only_if branch December 11, 2019 18:15
@firebase firebase locked and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants