Remove @visibleForTesting from FirebaseApp constructor #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
approved these changes
Nov 8, 2019
Contributor
collinjackson
left a comment
collinjackson
left a comment
There was a problem hiding this comment.
Thanks, this looks good. Can you add a TODO to keep track of which apps have been configured and assert that the app has previously been configured or been retrieved using appNamed?
Contributor
|
Also I think we should remove the const from the constructor since we might want to do runtime checks in the future. |
collinjackson
approved these changes
Nov 9, 2019
Co-Authored-By: Collin Jackson <[email protected]>
Co-Authored-By: Collin Jackson <[email protected]>
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove @VisibleForTesting annotation from FirebaseApp constructor. This will resolve CI issues while a new FirebaseApp creation strategy is WIP.