Skip to content

Update min Unity version and remove dotnet 3 support #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2022
Merged

Update min Unity version and remove dotnet 3 support #485

merged 3 commits into from
Oct 13, 2022

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Oct 12, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Update the minimum supported version of Unity to 2019. Also remove support for dotnet3, which involves removing the Parse libraries, and having two versions of the packages in the zip.

Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/3238547105

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice changed the title Remove dotnet 3 support Update min Unity version and remove dotnet 3 support Oct 13, 2022
cynthiajoan
cynthiajoan reviewed Oct 13, 2022
View reviewed changes
@a-maurice a-maurice marked this pull request as ready for review October 13, 2022 23:15
@a-maurice a-maurice requested a review from cynthiajoan October 13, 2022 23:18
@a-maurice a-maurice merged commit bdd9fd7 into main Oct 13, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Oct 14, 2022
@github-actions
Copy link

github-actions bot commented Oct 14, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit e32f1f4
Last updated: Thu Oct 13 22:26 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): iOS]
firestore [TEST] [FAILURE] [2019] [macos] [1/5 Platform(s): windows]
storage [TEST] [FAILURE] [2019] [macos] [1/5 Platform(s): Android] [android_target]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 14, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 14, 2022
@a-maurice a-maurice deleted the am-unity_versions branch October 20, 2022 17:56
@firebase firebase locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @cynthiajoan