Add null checks, and improve swig error handling #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
reviewed
Sep 3, 2024
messaging/src/swig/messaging.i
Outdated
| @@ -316,18 +316,22 @@ void SendPendingEvents() { | |||
| // messageReceivedDelegate. | |||
| [MonoPInvokeCallback(typeof(MessageReceivedDelegate))] | |||
| private static int MessageReceivedDelegateMethod(System.IntPtr message) { | |||
| int tookOwnership = 0; | |||
There was a problem hiding this comment.
If this has to be an int vs. a bool, add a comment for why?
jonsimantov
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing null checks to new Messaging conversion logic, and improve the swig conversion logic to better handle if an exception is thrown, to prevent a double free. This was causing a crash when opening a notification.
Testing
Running locally.
GHA: https://github.com/firebase/firebase-unity-sdk/actions/runs/10691311630
Type of Change
Place an
xthe applicable box:#1091