-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[FDC] Provide flutter as an option during init dataconnect
#9084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the firebase init dataconnect
command by integrating Flutter as a new app template choice, streamlining the setup process for Flutter developers. Additionally, it refactors a core utility function, centralizing it for improved reusability and maintainability across the codebase.
Highlights
- New App Template Option: The
firebase init dataconnect
command now includes Flutter as a selectable app template option, allowing users to quickly set up new Flutter projects. - Utility Function Centralization: The
commandExistsSync
utility function has been relocated tosrc/utils.ts
, making it more broadly accessible and improving code organization.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds Flutter as an option for creating an app template during init dataconnect
. The changes include adding a createFlutterApp
function, updating the interactive prompt to include Flutter, and refactoring the commandExistsSync
utility function to a more general location. The implementation is solid. I've suggested a small refactoring to improve code clarity and avoid redundant filesystem calls.
[No rush at all, P2 no dealine] @maneesht I think you will like this change~ |
@@ -1 +1,2 @@ | |||
- `firebase emulator:start` use a default project if no project can be found. (#9072) | |||
- `firebase emulator:start` use a default project `demo-no-project` if no project can be found. (#9072) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressing feedback from a different PR #9072 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this
Success Demo
https://screencast.googleplex.com/cast/NDgyNDA3MzU1MjAwMzA3MnxhMGIzMjEwYS1mMQ
When
npx
orflutter
isn't installed: