Skip to content

Conversation

fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Sep 6, 2025

Success Demo

https://screencast.googleplex.com/cast/NDgyNDA3MzU1MjAwMzA3MnxhMGIzMjEwYS1mMQ

When npx or flutter isn't installed:

Screenshot 2025-09-05 at 5 08 34 PM

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the firebase init dataconnect command by integrating Flutter as a new app template choice, streamlining the setup process for Flutter developers. Additionally, it refactors a core utility function, centralizing it for improved reusability and maintainability across the codebase.

Highlights

  • New App Template Option: The firebase init dataconnect command now includes Flutter as a selectable app template option, allowing users to quickly set up new Flutter projects.
  • Utility Function Centralization: The commandExistsSync utility function has been relocated to src/utils.ts, making it more broadly accessible and improving code organization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Flutter as an option for creating an app template during init dataconnect. The changes include adding a createFlutterApp function, updating the interactive prompt to include Flutter, and refactoring the commandExistsSync utility function to a more general location. The implementation is solid. I've suggested a small refactoring to improve code clarity and avoid redundant filesystem calls.

@fredzqm
Copy link
Contributor Author

fredzqm commented Sep 6, 2025

[No rush at all, P2 no dealine]

@maneesht I think you will like this change~

@@ -1 +1,2 @@
- `firebase emulator:start` use a default project if no project can be found. (#9072)
- `firebase emulator:start` use a default project `demo-no-project` if no project can be found. (#9072)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing feedback from a different PR #9072 (comment)

Copy link
Contributor

@maneesht maneesht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this

@fredzqm fredzqm merged commit eea540a into master Sep 8, 2025
47 of 48 checks passed
@fredzqm fredzqm deleted the fz/fdc_flutter branch September 8, 2025 16:35
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants