Fixing an issue where MCP server would still hang on studio

[joehan]

Description

More Studio MCP fixes - if we're gonna not use ADC on Studio, we need to be consistent about it.

Scenarios Tested

Waiting for a workspace to warm up to test this properly.

[gemini-code-assist]

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue causing the MCP server to hang in the Studio environment by refining the authentication process. It introduces conditional logic to bypass Application Default Credentials (ADC) when operating within Studio, ensuring a more consistent and appropriate user experience for authentication prompts and preventing potential hangs related to ADC usage in that specific environment.

Highlights

• Authentication Error Messaging: The mcpAuthError function in src/mcp/errors.ts has been updated to accept a skipADC boolean parameter. This allows for conditional error messages: if skipADC is true, the message will only instruct the user to log in via the Firebase CLI, omitting any mention of Application Default Credentials (ADC).
• Studio Environment Authentication: In src/mcp/index.ts, a check for the isFirebaseStudio() environment has been introduced. The result of this check (skipAutoAuthForStudio) is now passed to both this.getAuthenticatedUser() and mcpAuthError(), ensuring that the authentication flow and error messages are tailored specifically for the Studio environment, bypassing ADC where appropriate.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request fixes an issue where the MCP server would hang in Firebase Studio by conditionally skipping Application Default Credentials (ADC) authentication. The changes correctly detect the Studio environment and adjust the authentication flow and error messages accordingly.

[joehan]

Tested on studio and works like a charm