Skip to content

Better error message when failing to fetch MOTD #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Better error message when failing to fetch MOTD #6556

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a43a7cf
Better error message when failing to fetch MOTD
joehan Nov 29, 2023
2e7f6e2
Update src/fetchMOTD.ts
joehan Nov 29, 2023
19d795e
format
joehan Nov 29, 2023
b1ca97a
Merge branch 'master' into jh-better-motd-error
joehan Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/fetchMOTD.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ export function fetchMOTD(): void {
configstore.set("motd.fetched", Date.now());
})
.catch((err) => {
utils.logWarning("Unable to fetch the CLI MOTD and remote config.");
utils.logWarning(
"Unable to fetch the CLI MOTD and remote config. This is not a fatal error, but may indicate an issue with your network connection."
);
logger.debug(`Failed to fetch MOTD ${err}`);
});
}
Expand Down