Skip to content

Correctly set FUNCTION_TARGET for grouped functions #6410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Correctly set FUNCTION_TARGET for grouped functions #6410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
576b6be
Correctly set FUNCTION_TARGET for grouped functions
joehan Sep 27, 2023
dae305f
Merge branch 'master' into jh-fix-cb
joehan Sep 27, 2023
1740bda
Merge branch 'master' into jh-fix-cb
joehan Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Fixed an issue with deploying function groups containing v2 functions. (#6408)
- Use GetDefaultBucket endpoint to fetch Storage Default Bucket.
4 changes: 2 additions & 2 deletions src/gcp/cloudfunctionsv2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ export async function createFunction(cloudFunction: InputCloudFunction): Promise

cloudFunction.serviceConfig.environmentVariables = {
...cloudFunction.serviceConfig.environmentVariables,
FUNCTION_TARGET: functionId,
FUNCTION_TARGET: functionId.replace("-", "."),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'replace' only replaces first instance of the search string. It should be using 'replaceAll'.

};

try {
Expand Down Expand Up @@ -439,7 +439,7 @@ export async function updateFunction(cloudFunction: InputCloudFunction): Promise

cloudFunction.serviceConfig.environmentVariables = {
...cloudFunction.serviceConfig.environmentVariables,
FUNCTION_TARGET: functionId,
FUNCTION_TARGET: functionId.replace("-", "."),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'replace' only replaces first instance of the search string. It should be using 'replaceAll'.

};

try {
Expand Down