feat: support Python functions runtime for init & deploy
#4653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into cf3-dev-py
…nto functions-python
inlined
approved these changes
Jun 26, 2022
Codecov ReportBase: 56.32% // Head: 56.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4653 +/- ##
==========================================
- Coverage 56.32% 56.15% -0.18%
==========================================
Files 315 315
Lines 21324 21331 +7
Branches 4349 4350 +1
==========================================
- Hits 12011 11978 -33
- Misses 8272 8312 +40
Partials 1041 1041
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Salakar
commented
Jul 27, 2022
jamesdaniels
requested changes
Dec 6, 2022
| */ | ||
| export async function setup(_setup: unknown, config: Config): Promise<void> { | ||
| await config.askWriteProjectFile( | ||
| `${Config.DEFAULT_FUNCTIONS_SOURCE}/requirements.txt`, |
There was a problem hiding this comment.
should use setup.functions.source rather than default here & in other spots
jamesdaniels
reviewed
Dec 7, 2022
| import { FirebaseError } from "../../../../error"; | ||
| import { Build } from "../../build"; | ||
|
|
||
| export const LATEST_VERSION: runtimes.Runtime = "python310"; |
There was a problem hiding this comment.
FYI latest is now python311
There was a problem hiding this comment.
Is it supported in GCF? Per https://cloud.google.com/functions/docs/concepts/python-runtime, I dont see python311.
There was a problem hiding this comment.
Hmm, maybe I jumped the gun I was looking a cs
jamesdaniels
reviewed
Dec 8, 2022
| ...envs, | ||
| ADMIN_PORT: port.toString(), | ||
| }; | ||
| const args = ["python3.10", path.join(modulesDir, "private", "serving.py")]; |
There was a problem hiding this comment.
probably best not to hardcode here, maybe make an const
jamesdaniels
reviewed
Dec 8, 2022
| config.set("functions.ignore", ["venv", "__pycache__"]); | ||
| // Setup VENV. | ||
| await runWithVirtualEnv( | ||
| ["python3.10", "-m", "venv", "venv"], |
There was a problem hiding this comment.
same here, best not to hardcode python3.10, use a shared const
…nto functions-python
… into functions-python
taeold
added a commit
that referenced
this pull request
Jan 25, 2023
Add support for loading and serving functions written using the Firebase Functions Python SDK (WIP: https://github.com/firebase/firebase-functions-python) This PR is a fork of #4653 extended with support for emulating Python functions. Python Runtime Delegate implementation is unsurprising but does include some additional wrapper code to make sure all commands (e.g. spinning up the admin server) runs within the virtualenv environment. For now, we hardcode virtual environment `venv` directory exists on the developer's laptop, but we'll later add support for specifying arbitrary directory for specifying virtualenv directory via firebase.json configuration. Another note is that each emulated Python function will bind to a Port instead of Unix Domain Socket (UDS) as done when emulating Node.js function. This is because there is no straightfoward, platform-neutral way to bind python webserver to UDS. Finding large number of open port might have a bit more performance penalty and cause bugs due to race condition (similar to #5418) but it seems that we have no other choice atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A first pass at adding Python functions runtime support for
initanddeploy.cc @inlined @taeold
Scenarios Tested
Sample Commands
firebase experiments:enable pythonfunctionsfirebase init functions(choose python)firebase deploy --only functions