Skip to content

feat(ai): Add HarmBlockThreshold.OFF #9050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

dlarocque
Copy link
Contributor

Add HarmBlockThreshold.OFF, which makes it so that no safetyRatings are included in the response (only if all other harm categories are also OFF).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/ai

    TypeBase (880110b)Merge (a46fbe6)Diff
    browser42.5 kB42.5 kB+32 B (+0.1%)
    main43.7 kB43.7 kB+32 B (+0.1%)
    module42.5 kB42.5 kB+32 B (+0.1%)
  • firebase

    TypeBase (880110b)Merge (a46fbe6)Diff
    firebase-ai.js33.8 kB33.8 kB+12 B (+0.0%)
    firebase-vertexai.js33.8 kB33.8 kB+12 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/N2i6EtFujn.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/ai

    • AIError

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.43 kB4.44 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.3 kB+15 B (+0.1%)
    • AIModel

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size6.18 kB6.19 kB+15 B (+0.2%)
      size-with-ext-deps24.1 kB24.2 kB+15 B (+0.1%)
    • ArraySchema

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size6.22 kB6.23 kB+15 B (+0.2%)
      size-with-ext-deps24.1 kB24.2 kB+15 B (+0.1%)
    • Backend

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.43 kB4.44 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.3 kB+15 B (+0.1%)
    • BackendType

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.43 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.3 kB+15 B (+0.1%)
    • BlockReason

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.43 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.3 kB+15 B (+0.1%)
    • BooleanSchema

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size6.22 kB6.24 kB+15 B (+0.2%)
      size-with-ext-deps24.1 kB24.2 kB+15 B (+0.1%)
    • ChatSession

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size20.0 kB20.0 kB+15 B (+0.1%)
      size-with-ext-deps38.9 kB39.0 kB+15 B (+0.0%)
    • FinishReason

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.43 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.3 kB+15 B (+0.1%)
    • FunctionCallingMode

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.44 kB4.46 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • GenerativeModel

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size23.6 kB23.6 kB+15 B (+0.1%)
      size-with-ext-deps42.6 kB42.6 kB+15 B (+0.0%)
    • GoogleAIBackend

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.44 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • HarmBlockMethod

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.44 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • HarmBlockThreshold

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.44 kB4.46 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • HarmCategory

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.43 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.3 kB+15 B (+0.1%)
    • HarmProbability

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.44 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • HarmSeverity

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.43 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.3 kB+15 B (+0.1%)
    • ImagenAspectRatio

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.44 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • ImagenImageFormat

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.72 kB4.73 kB+15 B (+0.3%)
      size-with-ext-deps22.6 kB22.6 kB+15 B (+0.1%)
    • ImagenModel

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size11.3 kB11.3 kB+15 B (+0.1%)
      size-with-ext-deps29.3 kB29.3 kB+15 B (+0.1%)
    • ImagenPersonFilterLevel

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.45 kB4.46 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • ImagenSafetyFilterLevel

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.45 kB4.46 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • IntegerSchema

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size6.22 kB6.24 kB+15 B (+0.2%)
      size-with-ext-deps24.1 kB24.2 kB+15 B (+0.1%)
    • Modality

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.43 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.3 kB+15 B (+0.1%)
    • NumberSchema

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size6.22 kB6.23 kB+15 B (+0.2%)
      size-with-ext-deps24.1 kB24.2 kB+15 B (+0.1%)
    • ObjectSchema

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size6.22 kB6.23 kB+15 B (+0.2%)
      size-with-ext-deps24.1 kB24.2 kB+15 B (+0.1%)
    • POSSIBLE_ROLES

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.48 kB4.50 kB+15 B (+0.3%)
      size-with-ext-deps22.4 kB22.4 kB+15 B (+0.1%)
    • ResponseModality

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.47 kB4.49 kB+15 B (+0.3%)
      size-with-ext-deps22.4 kB22.4 kB+15 B (+0.1%)
    • Schema

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size6.21 kB6.23 kB+15 B (+0.2%)
      size-with-ext-deps24.1 kB24.2 kB+15 B (+0.1%)
    • SchemaType

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.43 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.3 kB+15 B (+0.1%)
    • StringSchema

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size6.22 kB6.23 kB+15 B (+0.2%)
      size-with-ext-deps24.1 kB24.2 kB+15 B (+0.1%)
    • VertexAIBackend

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.44 kB4.45 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • VertexAIError

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.45 kB4.46 kB+15 B (+0.3%)
      size-with-ext-deps22.3 kB22.4 kB+15 B (+0.1%)
    • VertexAIModel

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size6.20 kB6.21 kB+15 B (+0.2%)
      size-with-ext-deps24.2 kB24.2 kB+15 B (+0.1%)
    • getAI

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.79 kB4.81 kB+15 B (+0.3%)
      size-with-ext-deps30.0 kB30.0 kB+15 B (+0.0%)
    • getGenerativeModel

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size23.8 kB23.8 kB+15 B (+0.1%)
      size-with-ext-deps42.8 kB42.8 kB+15 B (+0.0%)
    • getImagenModel

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size11.5 kB11.5 kB+15 B (+0.1%)
      size-with-ext-deps29.5 kB29.5 kB+15 B (+0.1%)
    • getVertexAI

      Size

      TypeBase (880110b)Merge (a46fbe6)Diff
      size4.83 kB4.84 kB+15 B (+0.3%)
      size-with-ext-deps30.1 kB30.1 kB+15 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ujYAMrmVOQ.html

@dlarocque dlarocque marked this pull request as ready for review May 21, 2025 17:21
@dlarocque dlarocque requested review from a team as code owners May 21, 2025 17:21
@dlarocque dlarocque requested a review from rachelsaunders May 22, 2025 15:09
@dlarocque dlarocque merged commit 8cb21ff into main May 27, 2025
38 checks passed
@dlarocque dlarocque deleted the dl/harmblockmethod-off branch May 27, 2025 14:34
mansisampat added a commit that referenced this pull request Jun 17, 2025
* Version Packages (#9016)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Revert "Fixed scroll behavior (#8977)" (#9053)

* Revert "Fixed scroll behavior (#9043)"

This reverts commit 9bcd1ea.

* Revert "Add Emulator Overlay (#8977) (#9031)"

This reverts commit 8593fa0.

* Undid revert of util

* Create dirty-crews-cross.md

* Removed unnecessary markdown file

* Updated to only show banner when calling connect*Emulator (#9055)

* Version Packages (#9054)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Close webchannel instances on terminate (#9041)

Explicitly close any unclosed WebChannel instances on Firestore#terminate()

* Reorder reporters to prevent log message duplication in CI (#9040)

* docs(ai): Fix 'occured' typo in error codes (#9021)

* feat(ai): Add `HarmBlockThreshold.OFF` (#9050)

* feat(ai): Schema `title`, `maximum`, `minimum`, and `propertyOrdering` (#9047)

* feat(ai): Add support for `minItems` and `maxItems` to `Schema` (#9026)

* Build out e2e subdirectories (#9065)

* Added test project to fdc (#8924)

* Version Packages (#9073)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Release version 11.9.0.

* test(ai): add integration tests (#8853)

* Update issue template to rename VertexAI > AI (#9074)

* ci: Fix Firefox error and streamline cross-browser tests (#9015)

* Fixed issue where requestSts wasn't including the Studio cookie in it (#9075)

* Fix issue where we ping an endpoint that hasn't been implemented (#9059)

* Updated firebase auth changeset (#9088)

* build(all): Version Packages v11.9.1 (#9089)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

v11.9.1 release.

* test(ai): Upgrade mock responses to v14 (#9091)

---------

Co-authored-by: Google Open Source Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Maneesh Tewani <[email protected]>
Co-authored-by: Mark Duckworth <[email protected]>
Co-authored-by: Daniel La Rocque <[email protected]>
Co-authored-by: Christina Holland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants