-
Notifications
You must be signed in to change notification settings - Fork 938
Added test project to fdc #8924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (af9f8b5) and merge commit (3d40478).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (af9f8b5) and merge commit (3d40478).Test Logs |
Vertex AI Mock Responses Check
|
integration/data-connect/yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file should be here anymore? If I remove it and yarn install from either the top level or in this directory, it doesn't make one.
yarn.lock
Outdated
@@ -1299,6 +1299,130 @@ | |||
resolved "https://registry.npmjs.org/@eslint/js/-/js-8.57.1.tgz#de633db3ec2ef6a3c89e2f19038063e8a122e2c2" | |||
integrity sha512-d9zaMRSTIKDLhctzH12MtXvJKSSUhaHcjV+2Z+GK+EEY7XKpP5yR4x+N3TAcHTcu963nIr+TMcCb4DBCYX1z6Q== | |||
|
|||
"@firebase/[email protected]": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be any @firebase
entries in yarn.lock. I'm not sure how, but in your branch, the version in packages/firebase/package.json
is set to 11.8.0. Also in integration/messaging/package.json
. When I do a git diff against main, there are a lot of diffed files you didn't seem to have touched in this PR, so I'm not sure what's going on. Maybe make a clean branch and just selectively git checkout the folder integration/data-connect
from this branch, plus the other 2 files you changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let me just re-merge origin/main
Changeset File Check ✅
|
…om/firebase/firebase-js-sdk into mtewani/add-more-integration-tests
Added an example for generated JS SDK tests