Skip to content

Added test project to fdc #8924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 30, 2025
Merged

Added test project to fdc #8924

merged 25 commits into from
May 30, 2025

Conversation

maneesht
Copy link
Contributor

Added an example for generated JS SDK tests

@maneesht maneesht requested review from aashishpatil-g and a team as code owners April 11, 2025 21:31
Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: 3ddd8e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2025

@maneesht maneesht requested a review from a team as a code owner April 23, 2025 18:08
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@maneesht maneesht requested a review from a team as a code owner May 21, 2025 17:39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file should be here anymore? If I remove it and yarn install from either the top level or in this directory, it doesn't make one.

yarn.lock Outdated
@@ -1299,6 +1299,130 @@
resolved "https://registry.npmjs.org/@eslint/js/-/js-8.57.1.tgz#de633db3ec2ef6a3c89e2f19038063e8a122e2c2"
integrity sha512-d9zaMRSTIKDLhctzH12MtXvJKSSUhaHcjV+2Z+GK+EEY7XKpP5yR4x+N3TAcHTcu963nIr+TMcCb4DBCYX1z6Q==

"@firebase/[email protected]":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be any @firebase entries in yarn.lock. I'm not sure how, but in your branch, the version in packages/firebase/package.json is set to 11.8.0. Also in integration/messaging/package.json. When I do a git diff against main, there are a lot of diffed files you didn't seem to have touched in this PR, so I'm not sure what's going on. Maybe make a clean branch and just selectively git checkout the folder integration/data-connect from this branch, plus the other 2 files you changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let me just re-merge origin/main

Copy link
Contributor

github-actions bot commented May 23, 2025

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@maneesht maneesht merged commit 30de503 into main May 30, 2025
37 of 38 checks passed
@maneesht maneesht deleted the mtewani/add-more-integration-tests branch May 30, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants