Skip to content

fix(vertexai): pass GenerativeModel's BaseParams to ChatSession #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(vertexai): pass GenerativeModel's BaseParams to ChatSession #8972

wants to merge 5 commits into from

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Apr 24, 2025 •
edited
Loading

DO NOT MERGE.

startChat wasn't passing GenerativeModel's BaseParams to ChatSession.
So, if a model had a generationConfig, it would never be passed to ChatSession.

This is how the other SDKs behave.

@dlarocque dlarocque requested a review from hsubox76 April 24, 2025 17:31
@dlarocque dlarocque requested a review from a team as a code owner April 24, 2025 17:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 102fb8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dlarocque dlarocque requested review from a team as code owners April 24, 2025 17:32
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (9952dbc)Merge (821e265)Diff
    browser193 kB193 kB+209 B (+0.1%)
    cordova166 kB166 kB+209 B (+0.1%)
    main147 kB147 kB+194 B (+0.1%)
    module193 kB193 kB+209 B (+0.1%)
    react-native165 kB165 kB+194 B (+0.1%)

  • @firebase/auth-cordova

    TypeBase (9952dbc)Merge (821e265)Diff
    browser166 kB166 kB+209 B (+0.1%)
    module166 kB166 kB+209 B (+0.1%)

  • @firebase/auth-web-extension

    TypeBase (9952dbc)Merge (821e265)Diff
    browser142 kB142 kB+209 B (+0.1%)
    main159 kB159 kB+200 B (+0.1%)
    module142 kB142 kB+209 B (+0.1%)

  • @firebase/auth/internal

    TypeBase (9952dbc)Merge (821e265)Diff
    browser204 kB204 kB+209 B (+0.1%)
    main173 kB174 kB+200 B (+0.1%)
    module204 kB204 kB+209 B (+0.1%)

  • @firebase/data-connect

    TypeBase (9952dbc)Merge (821e265)Diff
    browser21.4 kB21.7 kB+281 B (+1.3%)
    main23.7 kB23.9 kB+266 B (+1.1%)
    module21.4 kB21.7 kB+281 B (+1.3%)

  • @firebase/database

    TypeBase (9952dbc)Merge (821e265)Diff
    browser249 kB249 kB+211 B (+0.1%)
    main254 kB254 kB+196 B (+0.1%)
    module249 kB249 kB+211 B (+0.1%)

  • @firebase/database-compat/standalone

    TypeBase (9952dbc)Merge (821e265)Diff
    main366 kB366 kB+196 B (+0.1%)

  • @firebase/firestore

    TypeBase (9952dbc)Merge (821e265)Diff
    browser384 kB385 kB+287 B (+0.1%)
    main594 kB595 kB+335 B (+0.1%)
    module384 kB385 kB+287 B (+0.1%)
    react-native384 kB385 kB+293 B (+0.1%)

  • @firebase/firestore-lite

    TypeBase (9952dbc)Merge (821e265)Diff
    browser114 kB114 kB+270 B (+0.2%)
    main157 kB157 kB+445 B (+0.3%)
    module114 kB114 kB+270 B (+0.2%)
    react-native114 kB114 kB+274 B (+0.2%)

  • @firebase/functions

    TypeBase (9952dbc)Merge (821e265)Diff
    browser14.0 kB14.1 kB+146 B (+1.0%)
    main14.6 kB14.7 kB+126 B (+0.9%)
    module14.0 kB14.1 kB+146 B (+1.0%)

  • @firebase/storage

    TypeBase (9952dbc)Merge (821e265)Diff
    browser58.0 kB58.4 kB+461 B (+0.8%)
    main59.4 kB60.0 kB+598 B (+1.0%)
    module58.0 kB58.4 kB+461 B (+0.8%)

  • @firebase/util

    TypeBase (9952dbc)Merge (821e265)Diff
    browser23.3 kB23.5 kB+223 B (+1.0%)
    main29.3 kB29.7 kB+395 B (+1.3%)
    module23.3 kB23.5 kB+223 B (+1.0%)

  • @firebase/vertexai

    TypeBase (9952dbc)Merge (821e265)Diff
    browser34.7 kB34.8 kB+75 B (+0.2%)
    main35.7 kB35.8 kB+75 B (+0.2%)
    module34.7 kB34.8 kB+75 B (+0.2%)

  • bundle

    39 size changes

    TypeBase (9952dbc)Merge (821e265)Diff
    auth (Anonymous)77.7 kB77.8 kB+132 B (+0.2%)
    auth (EmailAndPassword)87.8 kB87.9 kB+131 B (+0.1%)
    auth (GoogleFBTwitterGitHubPopup)105 kB105 kB+249 B (+0.2%)
    auth (GooglePopup)102 kB102 kB+131 B (+0.1%)
    auth (GoogleRedirect)102 kB102 kB+131 B (+0.1%)
    auth (Phone)95.2 kB95.3 kB+132 B (+0.1%)
    database (Append to a list of data)150 kB150 kB+231 B (+0.2%)
    database (Filtering data)149 kB149 kB+231 B (+0.2%)
    database (Listen for child events)165 kB165 kB+231 B (+0.1%)
    database (Listen for value events + Detach listeners)165 kB165 kB+231 B (+0.1%)
    database (Listen for value events)165 kB165 kB+231 B (+0.1%)
    database (Read data once)164 kB165 kB+231 B (+0.1%)
    database (Save data as transactions)167 kB167 kB+231 B (+0.1%)
    database (Sort data)150 kB151 kB+231 B (+0.2%)
    database (Write data)149 kB149 kB+231 B (+0.2%)
    firestore (CSI Auto Indexing Disable and Delete)274 kB275 kB+295 B (+0.1%)
    firestore (CSI Auto Indexing Enable)274 kB275 kB+295 B (+0.1%)
    firestore (Persistence)306 kB306 kB+295 B (+0.1%)
    firestore (Query Cursors)251 kB252 kB+297 B (+0.1%)
    firestore (Query)249 kB249 kB+297 B (+0.1%)
    firestore (Read data once)237 kB237 kB+297 B (+0.1%)
    firestore (Read Write w Persistence)330 kB331 kB+297 B (+0.1%)
    firestore (Realtime updates)239 kB239 kB+297 B (+0.1%)
    firestore (Transaction)216 kB216 kB+297 B (+0.1%)
    firestore (Write data)216 kB216 kB+297 B (+0.1%)
    firestore-lite (Query Cursors)104 kB105 kB+336 B (+0.3%)
    firestore-lite (Query)101 kB101 kB+336 B (+0.3%)
    firestore-lite (Read data once)75.9 kB76.3 kB+336 B (+0.4%)
    firestore-lite (Transaction)101 kB102 kB+336 B (+0.3%)
    firestore-lite (Write data)85.5 kB85.9 kB+336 B (+0.4%)
    functions (call)34.8 kB35.0 kB+197 B (+0.6%)
    storage (getBytes)42.4 kB42.8 kB+385 B (+0.9%)
    storage (getDownloadURL)44.5 kB44.9 kB+385 B (+0.9%)
    storage (getMetadata)44.0 kB44.3 kB+385 B (+0.9%)
    storage (list + listAll)43.4 kB43.8 kB+385 B (+0.9%)
    storage (updateMetadata)44.2 kB44.6 kB+385 B (+0.9%)
    storage (uploadBytes)49.1 kB49.5 kB+385 B (+0.8%)
    storage (uploadBytesResumable)59.0 kB59.4 kB+385 B (+0.7%)
    storage (uploadString)49.3 kB49.7 kB+385 B (+0.8%)

  • firebase

    16 size changes

    TypeBase (9952dbc)Merge (821e265)Diff
    firebase-auth-compat.js141 kB141 kB+207 B (+0.1%)
    firebase-auth-cordova.js138 kB138 kB+284 B (+0.2%)
    firebase-auth-web-extension.js120 kB121 kB+284 B (+0.2%)
    firebase-auth.js158 kB158 kB+284 B (+0.2%)
    firebase-compat.js797 kB797 kB+708 B (+0.1%)
    firebase-data-connect.js17.9 kB18.2 kB+302 B (+1.7%)
    firebase-database-compat.js164 kB164 kB+167 B (+0.1%)
    firebase-database.js187 kB187 kB+245 B (+0.1%)
    firebase-firestore-compat.js342 kB342 kB+259 B (+0.1%)
    firebase-firestore-lite.js132 kB133 kB+380 B (+0.3%)
    firebase-firestore.js443 kB443 kB+406 B (+0.1%)
    firebase-functions-compat.js10.4 kB10.5 kB+157 B (+1.5%)
    firebase-functions.js14.8 kB15.0 kB+224 B (+1.5%)
    firebase-storage-compat.js39.7 kB40.1 kB+330 B (+0.8%)
    firebase-storage.js46.3 kB46.7 kB+407 B (+0.9%)
    firebase-vertexai.js28.3 kB28.3 kB+75 B (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/M1NDGiSktc.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (483,180 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/j89tVml3CK.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v11.0

@dlarocque dlarocque requested a review from hsubox76 May 1, 2025 19:26
@dlarocque dlarocque requested a review from hsubox76 May 2, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@rachelsaunders rachelsaunders Awaiting requested review from rachelsaunders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlarocque @google-oss-bot @hsubox76