Build out e2e subdirectories (#9065)

Author: hsubox76

.github/workflows/e2e-test.yml

@@ -30,8 +30,8 @@ jobs:
 
     defaults:
       run:
-        # Run any command steps in the /e2e subdir
-        working-directory: './e2e'
+        # Run any command steps in the /e2e/smoke-tests subdir
+        working-directory: './e2e/smoke-tests'
 
     steps:
       - name: Checkout Repo
@@ -53,7 +53,9 @@ jobs:
       - name: Poll npm until version to test is available for install
         run: |
           echo "Polling npm for firebase@${{ github.event.client_payload.versionOrTag }}"
-          node ../scripts/release/poll-npm-publish.js
+          node ./scripts/release/poll-npm-publish.js
+        # run in root
+        working-directory: '.'
         env:
           VERSION: ${{ github.event.client_payload.versionOrTag }}
       - name: Yarn install

e2e/README.md

@@ -1,92 +1,11 @@
-# Firebase JS SDK E2E Tests
+# E2E Tests
 
-This directory contains end-to-end tests for the Firebase JS SDK package as well as minimal quick start sample apps for debugging and development.
+This directory is for Firebase E2E tests that are completely independent of the main SDK workspaces. Packages in here should:
 
-## E2E Tests
+* Have a start trigger independent of the main CI PR/push triggers (e.g., manual trigger, repository_dispatch, from an external runner like Kokoro, etc.)
+  
+  A common use case might be to clone this repo, cd into the chosen directory under e2e, npm install, and run npm scripts.
 
-### Setup
+* Have a self-contained set of NPM dependencies. They should not depend on the local version of Firebase in the SDK nor assume inherited availability of any packages in the top level package.json of this repo (typescript, firebase, karma, etc.).
 
-Before running the tests, you will need:
-
-- a project config
-- a test user with an email/password login which has read/write privileges for Storage, Realtime Database, and Firestore
-- an App Check debug token
-- to deploy the `callTest` Cloud Function
-
-#### Project Config and Test User
-
-Create a file named `firebase-config.js` in the top level of this `e2e/` directory. The contents of the file should be:
-
-```javascript
-// A config for a project
-export const config = {
-  apiKey: ************,
-  authDomain: ************,
-  databaseURL: ************,
-  projectId: ************,
-  storageBucket: ************,
-  messagingSenderId: ************,
-  appId: ************,
-  measurementId: ************
-};
- *
-// A user account with read/write privileges in that project
-// for storage, database, firestore
-export const testAccount = {
-  email: ************,
-  password: ************
-}
-```
-
-#### App Check Debug Token
-
-Create an App Check debug token in the Firebase Console. Assign it to an environment variable in your shell named `APP_CHECK_DEBUG_TOKEN`.
-
-#### Deploy `callTest` Cloud Function
-
-From the top level of the firebase repo, ensure you have the Firebase CLI (`firebase-tools`) installed (if not, `npm install -g firebase-tools`).
-
-Ensure you are logged in using the CLI (`firebase login`);
-
-Then deploy the function with:
-`firebase deploy --only functions:callTest --project YOUR_PROJECT_ID`
-
-### Running the Tests
-
-To run the tests on the default modular API:
-
-```
-yarn test:modular
-```
-
-To run the tests on the compat API:
-
-```
-yarn test:compat
-```
-
-## Sample Apps
-
-Two minimal sample apps are provided for quick debugging and development. These apps import and initialize every product in the SDK and call some basic methods. Products can easily be commented out to focus on one or more products you are interested in looking at.
-
-### Setup
-
-The setup is the same as for the E2E tests above. Certain tests can be skipped if you are commenting out that product (e.g, no need to deploy the Cloud Function if you are commenting out the `callFunctions()` line in the sample app, and no need to set the App Check debug token env variable if not using App Check).
-
-### Running Sample Apps
-
-To run the modular sample app (uses current default version of the API):
-
-```
-yarn start:modular
-```
-
-Then open `localhost:8080` in a browser.
-
-To run the compat sample app (uses current compat version of the API):
-
-```
-yarn start:compat
-```
-
-Then open `localhost:8080` in a browser.
+See the `template/` directory for an example.

e2e/.gitignore renamed to e2e/smoke-tests/.gitignore

@@ -0,0 +1,92 @@
+# Firebase JS SDK E2E Tests
+
+This directory contains end-to-end tests for the Firebase JS SDK package as well as minimal quick start sample apps for debugging and development.
+
+## E2E Tests
+
+### Setup
+
+Before running the tests, you will need:
+
+- a project config
+- a test user with an email/password login which has read/write privileges for Storage, Realtime Database, and Firestore
+- an App Check debug token
+- to deploy the `callTest` Cloud Function
+
+#### Project Config and Test User
+
+Create a file named `firebase-config.js` in the top level of this `e2e/smoke-tests` directory. The contents of the file should be:
+
+```javascript
+// A config for a project
+export const config = {
+  apiKey: ************,
+  authDomain: ************,
+  databaseURL: ************,
+  projectId: ************,
+  storageBucket: ************,
+  messagingSenderId: ************,
+  appId: ************,
+  measurementId: ************
+};
+ *
+// A user account with read/write privileges in that project
+// for storage, database, firestore
+export const testAccount = {
+  email: ************,
+  password: ************
+}
+```
+
+#### App Check Debug Token
+
+Create an App Check debug token in the Firebase Console. Assign it to an environment variable in your shell named `APP_CHECK_DEBUG_TOKEN`.
+
+#### Deploy `callTest` Cloud Function
+
+From the top level of the firebase repo, ensure you have the Firebase CLI (`firebase-tools`) installed (if not, `npm install -g firebase-tools`).
+
+Ensure you are logged in using the CLI (`firebase login`);
+
+Then deploy the function with:
+`firebase deploy --only functions:callTest --project YOUR_PROJECT_ID`
+
+### Running the Tests
+
+To run the tests on the default modular API:
+
+```
+yarn test:modular
+```
+
+To run the tests on the compat API:
+
+```
+yarn test:compat
+```
+
+## Sample Apps
+
+Two minimal sample apps are provided for quick debugging and development. These apps import and initialize every product in the SDK and call some basic methods. Products can easily be commented out to focus on one or more products you are interested in looking at.
+
+### Setup
+
+The setup is the same as for the E2E tests above. Certain tests can be skipped if you are commenting out that product (e.g, no need to deploy the Cloud Function if you are commenting out the `callFunctions()` line in the sample app, and no need to set the App Check debug token env variable if not using App Check).
+
+### Running Sample Apps
+
+To run the modular sample app (uses current default version of the API):
+
+```
+yarn start:modular
+```
+
+Then open `localhost:8080` in a browser.
+
+To run the compat sample app (uses current compat version of the API):
+
+```
+yarn start:compat
+```
+
+Then open `localhost:8080` in a browser.

e2e/smoke-tests/README.md

@@ -82,7 +82,7 @@ async function authLogout() {
  *
  * Call a deployed function.
  * This cloud function must be deployed in this project first. See
- * e2e/README.md for more info.
+ * e2e/smoke-test/README.md for more info.
  */
 async function callFunctions() {
   console.log('[FUNCTIONS] start');

e2e/babel.config.js renamed to e2e/smoke-tests/babel.config.js

@@ -121,7 +121,7 @@ async function authLogout(app) {
  *
  * Call a deployed function.
  * This cloud function must be deployed in this project first. See
- * e2e/README.md for more info.
+ * e2e/smoke-tests/README.md for more info.
  */
 async function callFunctions(app) {
   console.log('[FUNCTIONS] start');