Skip to content

Fix languageCode parameter in action_code_url #8912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
+13 −8
Merged

Fix languageCode parameter in action_code_url #8912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ec9d0
Fix languageCode parameter in action_code_url
pashanka Apr 9, 2025
0d4797a
Add changeset
pashanka Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-cheetahs-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/auth': patch
---

Fixed: `ActionCodeURL` not populating `languageCode` from the url.
14 changes: 7 additions & 7 deletions packages/auth/src/core/action_code_url.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('core/action_code_url', () => {
'oobCode=CODE&mode=signIn&apiKey=API_KEY&' +
'continueUrl=' +
encodeURIComponent(continueUrl) +
'&languageCode=en&tenantId=TENANT_ID&state=bla';
'&lang=en&tenantId=TENANT_ID&state=bla';
const actionCodeUrl = ActionCodeURL.parseLink(actionLink);
expect(actionCodeUrl!.operation).to.eq(ActionCodeOperation.EMAIL_SIGNIN);
expect(actionCodeUrl!.code).to.eq('CODE');
Expand All @@ -46,7 +46,7 @@ describe('core/action_code_url', () => {
const actionLink =
'https://www.example.com/finishSignIn?' +
'oobCode=CODE&mode=signIn&apiKey=API_KEY&' +
'languageCode=en';
'lang=en';
const actionCodeUrl = ActionCodeURL.parseLink(actionLink);
expect(actionCodeUrl!.operation).to.eq(
ActionCodeOperation.EMAIL_SIGNIN
Expand All @@ -57,7 +57,7 @@ describe('core/action_code_url', () => {
const actionLink =
'https://www.example.com/finishSignIn?' +
'oobCode=CODE&mode=verifyAndChangeEmail&apiKey=API_KEY&' +
'languageCode=en';
'lang=en';
const actionCodeUrl = ActionCodeURL.parseLink(actionLink);
expect(actionCodeUrl!.operation).to.eq(
ActionCodeOperation.VERIFY_AND_CHANGE_EMAIL
Expand All @@ -68,7 +68,7 @@ describe('core/action_code_url', () => {
const actionLink =
'https://www.example.com/finishSignIn?' +
'oobCode=CODE&mode=verifyEmail&apiKey=API_KEY&' +
'languageCode=en';
'lang=en';
const actionCodeUrl = ActionCodeURL.parseLink(actionLink);
expect(actionCodeUrl!.operation).to.eq(
ActionCodeOperation.VERIFY_EMAIL
Expand All @@ -79,7 +79,7 @@ describe('core/action_code_url', () => {
const actionLink =
'https://www.example.com/finishSignIn?' +
'oobCode=CODE&mode=recoverEmail&apiKey=API_KEY&' +
'languageCode=en';
'lang=en';
const actionCodeUrl = ActionCodeURL.parseLink(actionLink);
expect(actionCodeUrl!.operation).to.eq(
ActionCodeOperation.RECOVER_EMAIL
Expand All @@ -90,7 +90,7 @@ describe('core/action_code_url', () => {
const actionLink =
'https://www.example.com/finishSignIn?' +
'oobCode=CODE&mode=resetPassword&apiKey=API_KEY&' +
'languageCode=en';
'lang=en';
const actionCodeUrl = ActionCodeURL.parseLink(actionLink);
expect(actionCodeUrl!.operation).to.eq(
ActionCodeOperation.PASSWORD_RESET
Expand All @@ -101,7 +101,7 @@ describe('core/action_code_url', () => {
const actionLink =
'https://www.example.com/finishSignIn?' +
'oobCode=CODE&mode=revertSecondFactorAddition&apiKey=API_KEY&' +
'languageCode=en';
'lang=en';
const actionCodeUrl = ActionCodeURL.parseLink(actionLink);
expect(actionCodeUrl!.operation).to.eq(
ActionCodeOperation.REVERT_SECOND_FACTOR_ADDITION
Expand Down
2 changes: 1 addition & 1 deletion packages/auth/src/core/action_code_url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const enum QueryField {
API_KEY = 'apiKey',
CODE = 'oobCode',
CONTINUE_URL = 'continueUrl',
LANGUAGE_CODE = 'languageCode',
LANGUAGE_CODE = 'lang',
MODE = 'mode',
TENANT_ID = 'tenantId'
}
Expand Down
Loading