-
Notifications
You must be signed in to change notification settings - Fork 962
Add assertion IDs that will be included in production log statements for fail and hardAsserts #8313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
53603f3
Implement solution to replace error messages with error codes, instea…
MarkDuckworth c7c099a
Try-catch on saveErrorCode
MarkDuckworth 39cf218
Replace string errorCodes with numeric errorIds to make the bundles s…
MarkDuckworth d441861
Merge branch 'main' of github.com:firebase/firebase-js-sdk into markd…
MarkDuckworth 448257f
Added fixed error code values to source
MarkDuckworth 70dcaa7
Removed 4 characters from each error code
MarkDuckworth a86219b
Deduplicated an error code
MarkDuckworth 8b7c3f2
Fix tests
MarkDuckworth 26cdf17
Error codes numerically increasing starting at 0 with tools to create…
MarkDuckworth 8e28999
Instructions for using error-code-tool
MarkDuckworth 1733442
Create odd-wolves-sit.md
MarkDuckworth 3a1eaae
Rename error code to assertion id to deter customers from using this …
MarkDuckworth 3803a86
Assertion ID back to 4 digit hex
MarkDuckworth fef77fb
Updated assertion id tool to use hex string
MarkDuckworth 7416fa2
Merge branch 'markduckworth/error-codes' of github.com:firebase/fireb…
MarkDuckworth 70ebdc3
Update odd-wolves-sit.md
MarkDuckworth d2ef447
Update odd-wolves-sit.md
MarkDuckworth 4374a98
Address PR feedback
MarkDuckworth a46a147
Update prettier to run on scripts/ and commit the results of prettier
MarkDuckworth 0607d5b
Merge branch 'markduckworth/error-codes' of github.com:firebase/fireb…
MarkDuckworth 833f972
Fix lint error
MarkDuckworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@firebase/firestore": patch | ||
--- | ||
|
||
Add assertion IDs and optional context objects that will be included in production log statements for fail and hardAsserts | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.