Implement token revocation public api #7745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement revokeAccessToken * Fix token unit tests * Move ENDPOINT.TOKEN to /api/index.ts * Add unit tests * Set tenantId and remove redirectUri * Run doc generation and fix Lint errors * Remove unspecified token type
NhienLam
requested review from
egilmorez,
markarndt,
kevinthecheung,
lisajian,
prameshj,
renkelvin,
sam-gc and
a team
as code owners
🦋 Changeset detectedLatest commit: 0a26819 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Changeset File Check ✅
|
Size Analysis Report 1This report is too large (249,383 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
hsubox76
approved these changes
Nov 6, 2023
renkelvin
approved these changes
Nov 6, 2023
kevinthecheung
approved these changes
Nov 6, 2023
| @@ -514,6 +519,26 @@ export class AuthImpl implements AuthInternal, _FirebaseService { | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
| * Revokes the given access token. Currently only supports Apple OAuth Access token. | |||
There was a problem hiding this comment.
Suggested change
| * Revokes the given access token. Currently only supports Apple OAuth Access token. | |
| * Revokes the given access token. Currently only supports Apple OAuth access tokens. |
packages/auth/src/core/index.ts
Outdated
| @@ -245,6 +245,14 @@ export function signOut(auth: Auth): Promise<void> { | |||
| return getModularInstance(auth).signOut(); | |||
| } | |||
|
|
|||
| /** | |||
| * Revokes the given access token. Currently only supports Apple OAuth Access token. | |||
There was a problem hiding this comment.
Suggested change
| * Revokes the given access token. Currently only supports Apple OAuth Access token. | |
| * Revokes the given access token. Currently only supports Apple OAuth access tokens. |
egilmorez
approved these changes
Nov 6, 2023
kevinthecheung
approved these changes
Nov 6, 2023
Merged
prameshj
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Implement revokeAccessToken public api (#7541) * Implement revokeAccessToken * Fix token unit tests * Move ENDPOINT.TOKEN to /api/index.ts * Add unit tests * Set tenantId and remove redirectUri * Run doc generation and fix Lint errors * Remove unspecified token type * Clean up demo app * Add changeset * Update changeset * Fix refdoc comments * Run yarn docgen devsite
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only supports Apple OAuth Access token revocation.