Skip to content

Skip large sized bloom filter golden tests #7537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2023
Merged

Skip large sized bloom filter golden tests #7537

merged 2 commits into from
Aug 8, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Aug 8, 2023

No description provided.

@milaGGL milaGGL requested review from a team as code owners August 8, 2023 14:50
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0d9b8a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 8, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (c9e2b0b) and merge commit (f0fd5ed).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jsOK4x45Iz.html

dconeybe
dconeybe requested changes Aug 8, 2023
View reviewed changes
packages/firestore/test/unit/remote/bloom_filter.test.ts Outdated
@@ -198,25 +198,34 @@ describe('BloomFilter', () => {
TEST_DATA.count5000Rate0001TestResult
);
});
it('mightContain result for 50000 documents with 1 false positive rate', () => {

// Skip the large sized golden tests below as they are flaky on CI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update these comment to also explain why they are flaky in CI. Actually, I'd just omit the wording about "flaky" and just say that they are very slow and slow down unit test runs without adding much additional coverage compared to the other golden tests.

@milaGGL milaGGL requested a review from dconeybe August 8, 2023 15:35
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 8, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (c9e2b0b) and merge commit (f0fd5ed).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/agsEYLgGKz.html

MarkDuckworth
MarkDuckworth approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milaGGL milaGGL merged commit f73b24d into master Aug 8, 2023
@milaGGL milaGGL deleted the mila/skip-large-golden-tests branch August 8, 2023 19:40
@firebase firebase locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milaGGL @google-oss-bot @MarkDuckworth @dconeybe