Skip to content

Fix RUTv2 compat instances not working with modular. #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yuchenshi merged 2 commits into from
Sep 16, 2021
Merged

Fix RUTv2 compat instances not working with modular. #5500

yuchenshi merged 2 commits into from
Sep 16, 2021

Conversation

@yuchenshi
Copy link
Member

@yuchenshi yuchenshi commented Sep 16, 2021 •
edited
Loading

Fixes a typescript issue found in #4715 (reply in thread)

@yuchenshi yuchenshi requested a review from Feiyang1 September 16, 2021 00:24
@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 20d10b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@yuchenshi yuchenshi merged commit 46d26ff into master Sep 16, 2021
@yuchenshi yuchenshi deleted the ys/rut-interop-fix branch September 16, 2021 21:33
@google-oss-bot google-oss-bot mentioned this pull request Sep 21, 2021
Merged
@sceee sceee mentioned this pull request Sep 27, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@avolkovi avolkovi Awaiting requested review from avolkovi

@sam-gc sam-gc Awaiting requested review from sam-gc

@egilmorez egilmorez Awaiting requested review from egilmorez

1 more reviewer

@Feiyang1 Feiyang1 Feiyang1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Feiyang1 Feiyang1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuchenshi @Feiyang1