Skip to content

Conversation

@daymxn
Copy link
Member

@daymxn daymxn commented Oct 8, 2025

This PR updates the encrypted GoogleService-Info.plist files for the AI integration tests; aligning them with the new bundle ID (com.google.firebase.FirebaseAITestApp).

#no-changelog

@daymxn daymxn requested a review from andrewheard October 8, 2025 23:16
@daymxn daymxn self-assigned this Oct 8, 2025
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @daymxn! I think it would be good to move these files (and scripts/gha-encrypted/VertexAI/TestApp-Credentials.swift.gpg) to a FirebaseAI directory. Alternatively, we could merge as is and move them in a follow-up PR.

I noticed that the firebaseai workflow didn't run on this PR so I kicked it off manually. After we move the files (either in this PR or a follow-up), I think we should add scripts/gha-encrypted/FirebaseAI/ to:

pull_request:
paths:
- 'FirebaseAI**'
- '.github/workflows/firebaseai.yml'
- '.github/workflows/common.yml'
- '.github/workflows/common_cocoapods.yml'
- 'scripts/quickstart_build_spm.sh'
- 'scripts/update_firebase_spm_dependency.sh'
- 'Gemfile*'
# Do not run for documentation-only PRs.
- '!**.md'

Let me know which approach you'd prefer. This LGTM once we verify that the integration tests pass (it passed).

@daymxn daymxn requested a review from andrewheard October 9, 2025 16:54
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daymxn daymxn merged commit dcba494 into main Oct 9, 2025
51 checks passed
@daymxn daymxn deleted the dlr/update-test-app-secrets branch October 9, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants