Skip to content

Fix grpc version in cmake #15391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
+11 −2
Merged

Fix grpc version in cmake #15391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a41da3a
fix grpc
cherylEnkidu Oct 7, 2025
e79bcf0
Mark grpc as system library
cherylEnkidu Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Firestore/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,15 @@ target_include_directories(
${PROJECT_SOURCE_DIR}/Firestore/core/include
)

# Add the gRPC include directories as SYSTEM directories to silence warnings
target_include_directories(
firestore_core
SYSTEM # The SYSTEM keyword applies to all directories in this block
PUBLIC
# This generator expression automatically gets the correct include path(s) from the grpc++ target
$<TARGET_PROPERTY:grpc++,INTERFACE_INCLUDE_DIRECTORIES>
)

target_link_libraries(
firestore_core PUBLIC
LevelDB::LevelDB
Expand Down
4 changes: 2 additions & 2 deletions cmake/external/grpc.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ if(TARGET grpc)
return()
endif()

set(version 1.62.0)
set(version 1.69.0)

ExternalProject_Add(
grpc

DOWNLOAD_DIR ${FIREBASE_DOWNLOAD_DIR}
DOWNLOAD_NAME grpc-${version}.tar.gz
URL https://github.com/grpc/grpc/archive/v${version}.tar.gz
URL_HASH SHA256=f40bde4ce2f31760f65dc49a2f50876f59077026494e67dccf23992548b1b04f
URL_HASH SHA256=cd256d91781911d46a57506978b3979bfee45d5086a1b6668a3ae19c5e77f8dc

PREFIX ${PROJECT_BINARY_DIR}
SOURCE_DIR ${PROJECT_BINARY_DIR}/src/grpc
Expand Down
Loading