Fix double free bug inside IN Filter #10535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylEnkidu
force-pushed
the
cheryllin/FixINFilter
branch
from
407cd34 to
caeef58
Compare
cherylEnkidu
force-pushed
the
cheryllin/FixINFilter
branch
from
caeef58 to
ca2534e
Compare
Coverage Report 1Affected Products
Test Logs |
ehsannas
approved these changes
Nov 30, 2022
Closed
10 tasks
dconeybe
added a commit
to firebase/firebase-cpp-sdk
that referenced
this pull request
Dec 12, 2022
jonsimantov
pushed a commit
to firebase/firebase-cpp-sdk
that referenced
this pull request
Dec 13, 2022
* Update mobile dependencies - Mon Dec 12 2022 ### Android - com.google.firebase.firebase_bom → 31.1.1 ### iOS - Firebase/Analytics → 10.3.0 - Firebase/AppCheck → 10.3.0 - Firebase/Auth → 10.3.0 - Firebase/Core → 10.3.0 - Firebase/Crashlytics → 10.3.0 - Firebase/Database → 10.3.0 - Firebase/DynamicLinks → 10.3.0 - Firebase/Firestore → 10.3.0 - Firebase/Functions → 10.3.0 - Firebase/Installations → 10.3.0 - Firebase/Messaging → 10.3.0 - Firebase/RemoteConfig → 10.3.0 - Firebase/Storage → 10.3.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/3678546871). * Re-enable Firestore QueryTest.TestQueriesCanUseInFilters since 10.3.0 includes the fix (firebase/firebase-ios-sdk#10535) Co-authored-by: firebase-workflow-trigger-bot <[email protected]> Co-authored-by: Denver Coneybeare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10507 Bug is due to the ownership of nanopb value is shared by different variables. The pointer frees twice which leads to crash.