Missing tvOS Analytics dependency in AnalyticsWithoutAdIdSupport subspec

[alexzchut]

Step 0: Are you in the right place?

• For issues or feature requests related to the code in this repository
  file a GitHub issue.
  • If this is a feature request please use the Feature Request template.
• For general technical questions, post a question on StackOverflow
  with the firebase tag.
• For general (non-iOS) Firebase discussion, use the firebase-talk
  google group.
• For backend issues, console issues, and other non-SDK help that does not fall under one
  of the above categories, reach out to
  Firebase Support.
• Once you've read this section and determined that your issue is appropriate for
  this repository, please delete this section.

[REQUIRED] Step 1: Describe your environment

• Xcode version: 13.3.1
• Firebase SDK version: 8.15.0
• Installation method: CocoaPods | Carthage | Zip file | Swift Package Manager CocoaPods
• Firebase Component: Analytics (Auth, Core, Database, Firestore, Messaging, Storage, etc)
• Target platform(s): All | iOS | Catalyst | macOS | tvOS | watchOS - tvOS

[REQUIRED] Step 2: Describe the problem

Missing Analytics dependency when using AnalyticsWithoutAdIdSupport subspec for tvOS

Steps to reproduce:

When installing Firebase Analytics for tvOS, the dependent repository of FirebaseAnalytics is limited to iOS only and not installed when targeting for tvOS.

What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.

Relevant Code:

s.subspec 'AnalyticsWithoutAdIdSupport' do |ss|
ss.ios.deployment_target = '10.0'
ss.osx.deployment_target = '10.12'
ss.tvos.deployment_target = '12.0'
ss.ios.dependency 'FirebaseAnalytics/WithoutAdIdSupport', '~> 8.15.0'
ss.dependency 'Firebase/CoreOnly'
end

// TODO(you): code here to reproduce the problem

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[paulb777]

@alexzchut Thanks for the issue and the PR! At first glance, this looks like an oversight and a good fix.

In the interim, a workaround should be to directly add FirebaseAnalytics/WithoutAdIdSupport to the Podfile.

[alexzchut]

@paulb777 yes, thats what I am actually doing for now, until this will be fixed in podspec

[tsunghung]

@alexzchut Thanks for the issue report and the fix!

[paulb777]

Note that with Firebase 9.0, we are now recommending against using the Firebase pod, since it may not be feasible to support as we move more of the implementation to Swift.

Thus, FirebaseAnalytics/WithoutAdIdSupport is now the recommended usability.

Nonetheless, there's no reason to remove support for the Firebase pod early so we'll merge this now. Thanks!