Skip to content

Commit 1d84d5d

Browse files
committed
Review and zip build
1 parent e74262b commit 1d84d5d

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

FirebaseRemoteConfigSwift/Sources/Codable.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public extension RemoteConfig {
5757
encoder: FirebaseDataEncoder = FirebaseDataEncoder()) throws {
5858
guard let encoded = try encoder.encode(value) as? [String: NSObject] else {
5959
throw RemoteConfigCodableError.invalidSetDefaultsInput(
60-
"The setDefaults input \(value) must be a dictionary keyed by a String"
60+
"The setDefaults input \(value) must be a Struct that encodes to a Dictionary"
6161
)
6262
}
6363
setDefaults(encoded)

FirebaseRemoteConfigSwift/Sources/Value.swift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,16 @@ import FirebaseRemoteConfig
2020
/// Implements subscript overloads to enable Remote Config values to be accessed
2121
/// in a type-safe way directly from the current config.
2222
public extension RemoteConfig {
23+
/// Return a typed RemoteConfigValue for a key.
24+
/// - Parameter key: A Remote Config key.
25+
/// - Returns: A typed RemoteConfigValue.
2326
subscript<T: Decodable>(decodedValue key: String) -> T? {
2427
return try? configValue(forKey: key).decoded()
2528
}
2629

30+
/// Return a Dictionary for a RemoteConfig JSON key.
31+
/// - Parameter key: A Remote Config key.
32+
/// - Returns: A Dictionary representing a RemoteConfig JSON value.
2733
subscript(jsonValue key: String) -> [String: AnyHashable]? {
2834
guard let value = configValue(forKey: key).jsonValue as? [String: AnyHashable] else {
2935
// nil is the historical behavior for failing to extract JSON.

ReleaseTooling/Sources/FirebaseManifest/FirebaseManifest.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import Foundation
2323
public let shared = Manifest(
2424
version: "8.11.0",
2525
pods: [
26+
Pod("FirebaseSharedSwift"),
2627
Pod("FirebaseCoreDiagnostics", zip: true),
2728
Pod("FirebaseCore", zip: true),
2829
Pod("FirebaseInstallations", zip: true),
@@ -32,7 +33,7 @@ public let shared = Manifest(
3233
Pod("FirebaseABTesting", zip: true),
3334
Pod("FirebaseAppCheck", isBeta: true, zip: true),
3435
Pod("FirebaseRemoteConfig", zip: true),
35-
Pod("FirebaseSharedSwift"),
36+
Pod("FirebaseRemoteConfigSwift", isBeta: true),
3637
Pod("FirebaseAppDistribution", isBeta: true, platforms: ["ios"], zip: true),
3738
Pod("FirebaseAuth", zip: true),
3839
Pod("FirebaseCrashlytics", zip: true),

0 commit comments

Comments
 (0)