decodedValue subscript

Author: paulb777

FirebaseRemoteConfigSwift/Sources/Value.swift

@@ -20,40 +20,8 @@ import FirebaseRemoteConfig
 /// Implements subscript overloads to enable Remote Config values to be accessed
 /// in a type-safe way directly from the current config.
 public extension RemoteConfig {
-  subscript(stringValue key: String) -> String {
-    guard let value = configValue(forKey: key).stringValue else {
-      // An empty string is the historical behavior for an non-existent key.
-      return ""
-    }
-    return value
-  }
-
-  subscript(intValue key: String) -> Int {
-    return configValue(forKey: key).numberValue.intValue
-  }
-
-  subscript(uintValue key: String) -> UInt {
-    return configValue(forKey: key).numberValue.uintValue
-  }
-
-  subscript(numberValue key: String) -> NSNumber {
-    return configValue(forKey: key).numberValue
-  }
-
-  subscript(floatValue key: String) -> Float {
-    return configValue(forKey: key).numberValue.floatValue
-  }
-
-  subscript(doubleValue key: String) -> Double {
-    return configValue(forKey: key).numberValue.doubleValue
-  }
-
-  subscript(boolValue key: String) -> Bool {
-    return configValue(forKey: key).boolValue
-  }
-
-  subscript(dataValue key: String) -> Data {
-    return configValue(forKey: key).dataValue
+  subscript<T: Decodable>(decodedValue key: String) -> T? {
+    return try? configValue(forKey: key).decoded()
   }
 
   subscript(jsonValue key: String) -> [String: AnyHashable]? {

FirebaseRemoteConfigSwift/Tests/SwiftAPI/Value.swift

@@ -55,16 +55,14 @@ import XCTest
     func testStrongTypingViaSubscriptApi() async throws {
       let status = try await config.fetchAndActivate()
       XCTAssertEqual(status, .successFetchedFromRemote)
-      XCTAssertEqual(config[stringValue: Constants.stringKey], Constants.stringValue)
-      XCTAssertEqual(config[intValue: Constants.intKey], Constants.intValue)
-      XCTAssertEqual(config[numberValue: Constants.intKey],
-                     NSNumber(integerLiteral: Constants.intValue))
-      XCTAssertEqual(config[floatValue: Constants.floatKey], Constants.floatValue)
-      XCTAssertEqual(config[doubleValue: Constants.floatKey], Constants.doubleValue)
-      XCTAssertEqual(config[boolValue: Constants.trueKey], true)
-      XCTAssertEqual(config[boolValue: Constants.falseKey], false)
-      XCTAssertEqual(
-        config[dataValue: Constants.stringKey],
+      XCTAssertEqual(config[decodedValue: Constants.stringKey], Constants.stringValue)
+      XCTAssertEqual(config[decodedValue: Constants.intKey], Constants.intValue)
+      XCTAssertEqual(config[decodedValue: Constants.floatKey], Constants.floatValue)
+      XCTAssertEqual(config[decodedValue: Constants.floatKey], Constants.doubleValue)
+      XCTAssertEqual(config[decodedValue: Constants.trueKey], true)
+      XCTAssertEqual(config[decodedValue: Constants.falseKey], false)
+      XCTAssertEqual(
+        config[decodedValue: Constants.stringKey],
         Constants.stringValue.data(using: .utf8)
       )
       XCTAssertEqual(try XCTUnwrap(config[jsonValue: Constants.jsonKey]), Constants.jsonValue)
@@ -174,7 +172,7 @@ import XCTest
     }
 
     func testStringFails() {
-      XCTAssertEqual(config[stringValue: "UndefinedKey"], "")
+      XCTAssertEqual(config[decodedValue: "UndefinedKey"], "")
     }
 
     func testJSONFails() {