Skip to content

Enable users to define async HTTP functions #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2020
Merged

Enable users to define async HTTP functions #651

merged 2 commits into from
Mar 31, 2020

Conversation

sk-
Copy link
Contributor

@sk- sk- commented Mar 31, 2020

Fixes #606

@laurenzlong laurenzlong changed the title Allow to await async http functions Enable users to define async HTTP functions Mar 31, 2020
laurenzlong
laurenzlong approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@laurenzlong laurenzlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@laurenzlong laurenzlong merged commit 7f4c957 into firebase:master Mar 31, 2020
@sk-
Copy link
Contributor Author

sk- commented Mar 31, 2020

@laurenzlong somewhat related to this PR, should we update the handler type of both onRequest and _onRequestWithOptions to handler: (req: Request, resp: express.Response) => void | Promise<void>?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenzlong laurenzlong laurenzlong approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing async firebase functions.https.onRequest does not await
3 participants
@sk- @laurenzlong @googlebot